* [PATCH] drivers/phy: remove unneeded ret variable
@ 2022-02-10 6:05 cgel.zte
0 siblings, 0 replies; only message in thread
From: cgel.zte @ 2022-02-10 6:05 UTC (permalink / raw)
To: kishon; +Cc: vkoul, linux-phy, linux-kernel, Minghao Chi (CGEL ZTE), Zeal Robot
From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
Return value from regmap_update_bits() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
---
drivers/phy/ti/phy-ti-pipe3.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/ti/phy-ti-pipe3.c b/drivers/phy/ti/phy-ti-pipe3.c
index 2cbc91e535d4..060b68c69ab8 100644
--- a/drivers/phy/ti/phy-ti-pipe3.c
+++ b/drivers/phy/ti/phy-ti-pipe3.c
@@ -318,7 +318,6 @@ static void ti_pipe3_disable_clocks(struct ti_pipe3 *phy);
static int ti_pipe3_power_off(struct phy *x)
{
- int ret;
struct ti_pipe3 *phy = phy_get_drvdata(x);
if (!phy->phy_power_syscon) {
@@ -326,9 +325,8 @@ static int ti_pipe3_power_off(struct phy *x)
return 0;
}
- ret = regmap_update_bits(phy->phy_power_syscon, phy->power_reg,
+ return regmap_update_bits(phy->phy_power_syscon, phy->power_reg,
PIPE3_PHY_PWRCTL_CLK_CMD_MASK, 0);
- return ret;
}
static void ti_pipe3_calibrate(struct ti_pipe3 *phy);
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-10 6:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 6:05 [PATCH] drivers/phy: remove unneeded ret variable cgel.zte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).