From: Yury Norov <yury.norov@gmail.com>
To: "Yury Norov" <yury.norov@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"David Laight" <David.Laight@aculab.com>,
"Joe Perches" <joe@perches.com>,
"Dennis Zhou" <dennis@kernel.org>,
"Emil Renner Berthing" <kernel@esmil.dk>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Alexey Klimov" <aklimov@redhat.com>,
linux-kernel@vger.kernel.org,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Srikar Dronamraju" <srikar@linux.vnet.ibm.com>,
"Gautham R. Shenoy" <ego@linux.vnet.ibm.com>,
"Valentin Schneider" <valentin.schneider@arm.com>,
"Parth Shah" <parth@linux.ibm.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Hari Bathini" <hbathini@linux.ibm.com>,
"Rob Herring" <robh@kernel.org>,
"Laurent Dufour" <ldufour@linux.ibm.com>,
"Petr Mladek" <pmladek@suse.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
"Xiongwei Song" <sxwjean@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 38/49] arch/powerpc: replace cpumask_weight with cpumask_weight_{eq, ...} where appropriate
Date: Thu, 10 Feb 2022 14:49:22 -0800 [thread overview]
Message-ID: <20220210224933.379149-39-yury.norov@gmail.com> (raw)
In-Reply-To: <20220210224933.379149-1-yury.norov@gmail.com>
PowerPC code uses cpumask_weight() to compare the weight of cpumask with
a given number. We can do it more efficiently with cpumask_weight_{eq, ...}
because conditional cpumask_weight may stop traversing the cpumask earlier,
as soon as condition is (or can't be) met.
Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
arch/powerpc/kernel/smp.c | 2 +-
arch/powerpc/kernel/watchdog.c | 2 +-
arch/powerpc/xmon/xmon.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index b7fd6a72aa76..8bff748df402 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -1656,7 +1656,7 @@ void start_secondary(void *unused)
if (has_big_cores)
sibling_mask = cpu_smallcore_mask;
- if (cpumask_weight(mask) > cpumask_weight(sibling_mask(cpu)))
+ if (cpumask_weight_gt(mask, cpumask_weight(sibling_mask(cpu))))
shared_caches = true;
}
diff --git a/arch/powerpc/kernel/watchdog.c b/arch/powerpc/kernel/watchdog.c
index bfc27496fe7e..62937a077de7 100644
--- a/arch/powerpc/kernel/watchdog.c
+++ b/arch/powerpc/kernel/watchdog.c
@@ -483,7 +483,7 @@ static void start_watchdog(void *arg)
wd_smp_lock(&flags);
cpumask_set_cpu(cpu, &wd_cpus_enabled);
- if (cpumask_weight(&wd_cpus_enabled) == 1) {
+ if (cpumask_weight_eq(&wd_cpus_enabled, 1)) {
cpumask_set_cpu(cpu, &wd_smp_cpus_pending);
wd_smp_last_reset_tb = get_tb();
}
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index fd72753e8ad5..b423812e94e0 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -469,7 +469,7 @@ static bool wait_for_other_cpus(int ncpus)
/* We wait for 2s, which is a metric "little while" */
for (timeout = 20000; timeout != 0; --timeout) {
- if (cpumask_weight(&cpus_in_xmon) >= ncpus)
+ if (cpumask_weight_ge(&cpus_in_xmon, ncpus))
return true;
udelay(100);
barrier();
@@ -1338,7 +1338,7 @@ static int cpu_cmd(void)
case 'S':
case 't':
cpumask_copy(&xmon_batch_cpus, &cpus_in_xmon);
- if (cpumask_weight(&xmon_batch_cpus) <= 1) {
+ if (cpumask_weight_le(&xmon_batch_cpus, 1)) {
printf("There are no other cpus in xmon\n");
break;
}
--
2.32.0
next prev parent reply other threads:[~2022-02-11 0:15 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 22:48 [PATCH v4 00/49] bitmap: optimize bitmap_weight() usage Yury Norov
2022-02-10 22:48 ` [PATCH 01/49] net: dsa: don't use bitmap_weight() in b53_arl_read() Yury Norov
2022-02-10 22:48 ` [PATCH 02/49] net: systemport: don't use bitmap_weight() in bcm_sysport_rule_set() Yury Norov
2022-02-10 22:48 ` [PATCH 03/49] net: mellanox: fix open-coded for_each_set_bit() Yury Norov
2022-02-11 9:01 ` David Laight
2022-02-10 22:48 ` [PATCH 04/49] iio: fix opencoded for_each_set_bit() Yury Norov
2022-02-11 8:45 ` Andy Shevchenko
2022-02-11 17:17 ` Christophe JAILLET
2022-06-04 15:41 ` Jonathan Cameron
2022-06-11 13:50 ` Jonathan Cameron
2022-02-10 22:48 ` [RFC PATCH 05/49] qed: rework qed_rdma_bmap_free() Yury Norov
2022-02-11 8:48 ` Andy Shevchenko
2022-02-10 22:48 ` [PATCH 06/49] nds32: perf: replace bitmap_weight with bitmap_empty where appropriate Yury Norov
2022-02-10 22:48 ` [PATCH 07/49] KVM: x86: " Yury Norov
2022-02-11 16:34 ` Sean Christopherson
2022-02-11 17:13 ` Christophe JAILLET
2022-02-11 17:19 ` Sean Christopherson
2022-02-11 17:47 ` Yury Norov
2022-02-10 22:48 ` [PATCH 08/49] drm: " Yury Norov
2022-02-11 2:11 ` Dmitry Baryshkov
2022-02-10 22:48 ` [PATCH 09/49] ice: replace bitmap_weight with bitmap_empty Yury Norov
2022-02-10 22:48 ` [PATCH 10/49] octeontx2-pf: replace bitmap_weight with bitmap_empty where appropriate Yury Norov
2022-02-10 22:48 ` [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in qed_roce_stop() Yury Norov
2022-02-10 22:48 ` [PATCH 12/49] perf: replace bitmap_weight with bitmap_empty where appropriate Yury Norov
2022-02-11 10:25 ` Mark Rutland
2022-02-11 17:59 ` Yury Norov
2022-02-11 17:27 ` Christophe JAILLET
2022-02-11 23:23 ` Yury Norov
2022-02-10 22:48 ` [PATCH 13/49] perf tools: " Yury Norov
2022-02-10 22:48 ` [PATCH 14/49] arch/alpha: replace cpumask_weight with cpumask_empty " Yury Norov
2022-02-10 22:48 ` [PATCH 15/49] arch/ia64: " Yury Norov
2022-02-10 22:49 ` [PATCH 16/49] arch/x86: " Yury Norov
2022-04-10 20:42 ` [tip: x86/cleanups] x86: Replace cpumask_weight() with cpumask_empty() " tip-bot2 for Yury Norov
2022-02-10 22:49 ` [PATCH 17/49] cpufreq: replace cpumask_weight with cpumask_empty " Yury Norov
2022-02-11 4:30 ` Viresh Kumar
2022-02-11 5:17 ` Yury Norov
2022-02-10 22:49 ` [PATCH 18/49] drm/i915/pmu: " Yury Norov
2022-02-10 22:49 ` [PATCH 19/49] RDMA/hfi: " Yury Norov
2022-02-11 19:10 ` Jason Gunthorpe
2022-02-10 22:49 ` [PATCH 20/49] irq: mips: " Yury Norov
2022-04-10 20:34 ` [tip: irq/core] irqchip/bmips: Replace cpumask_weight() with cpumask_empty() tip-bot2 for Yury Norov
2022-02-10 22:49 ` [PATCH 21/49] genirq/affinity: replace cpumask_weight with cpumask_empty where appropriate Yury Norov
2022-04-10 20:27 ` [tip: irq/core] genirq/affinity: Replace cpumask_weight() with cpumask_empty() " tip-bot2 for Yury Norov
[not found] ` <573841649622719@mail.yandex.com>
2022-04-10 21:17 ` Yury Norov
2022-02-10 22:49 ` [PATCH 22/49] sched: replace cpumask_weight with cpumask_empty " Yury Norov
2022-02-11 10:19 ` Peter Zijlstra
2022-02-11 14:19 ` Yury Norov
2022-02-17 18:56 ` [tip: sched/core] " tip-bot2 for Yury Norov
2022-02-10 22:49 ` [PATCH 23/49] clocksource: replace cpumask_weight with cpumask_empty in clocksource.c Yury Norov
2022-04-10 20:35 ` [tip: timers/core] clocksource: Replace cpumask_weight() with cpumask_empty() tip-bot2 for Yury Norov
2022-02-10 22:49 ` [PATCH 24/49] mm/vmstat: replace cpumask_weight with cpumask_empty where appropriate Yury Norov
2022-02-11 10:39 ` Mike Rapoport
2022-02-10 22:49 ` [PATCH 25/49] arch/x86: replace nodes_weight with nodes_empty " Yury Norov
2022-04-10 20:42 ` [tip: x86/cleanups] x86/mm: Replace nodes_weight() with nodes_empty() " tip-bot2 for Yury Norov
2022-02-10 22:49 ` [PATCH 26/49] bitmap: add bitmap_weight_{cmp, eq, gt, ge, lt, le} functions Yury Norov
2022-02-10 22:49 ` [PATCH 27/49] arch/x86: replace bitmap_weight with bitmap_weight_{eq,gt,ge,lt,le} where appropriate Yury Norov
2022-02-10 22:49 ` [PATCH 28/49] iio: replace bitmap_weight() with bitmap_weight_{eq,gt} " Yury Norov
2022-02-10 22:49 ` [PATCH 29/49] memstick: replace bitmap_weight with bitmap_weight_eq " Yury Norov
2022-02-17 15:39 ` Ulf Hansson
2022-02-17 16:55 ` Yury Norov
2022-02-22 15:49 ` Ulf Hansson
2022-02-10 22:49 ` [PATCH 30/49] ixgbe: replace bitmap_weight with bitmap_weight_eq Yury Norov
2022-02-10 22:49 ` [PATCH 31/49] octeontx2-pf: replace bitmap_weight with bitmap_weight_{eq,gt} Yury Norov
2022-02-10 22:49 ` [PATCH 32/49] mlx4: replace bitmap_weight with bitmap_weight_{eq,gt,ge,lt,le} Yury Norov
2022-02-10 22:49 ` [PATCH 33/49] perf: replace bitmap_weight with bitmap_weight_eq for ThunderX2 Yury Norov
2022-02-11 10:30 ` Mark Rutland
2022-02-10 22:49 ` [PATCH 34/49] media: tegra-video: replace bitmap_weight with bitmap_weight_le Yury Norov
2022-04-28 7:31 ` Hans Verkuil
2022-02-10 22:49 ` [PATCH 35/49] cpumask: add cpumask_weight_{eq,gt,ge,lt,le} Yury Norov
2022-02-10 22:49 ` [PATCH 36/49] arch/ia64: replace cpumask_weight with cpumask_weight_eq in mm/tlb.c Yury Norov
2022-02-10 22:49 ` [PATCH 37/49] arch/mips: replace cpumask_weight with cpumask_weight_{eq, ...} where appropriate Yury Norov
2022-02-10 22:49 ` Yury Norov [this message]
2022-02-11 4:10 ` [PATCH 38/49] arch/powerpc: " Michael Ellerman
2022-02-10 22:49 ` [PATCH 39/49] arch/s390: replace cpumask_weight with cpumask_weight_eq " Yury Norov
2022-02-11 6:54 ` Sven Schnelle
2022-02-11 23:40 ` Yury Norov
2022-02-10 22:49 ` [PATCH 40/49] firmware: pcsi: replace cpumask_weight with cpumask_weight_eq Yury Norov
2022-02-11 9:45 ` Sudeep Holla
2022-02-11 10:32 ` Mark Rutland
2022-02-10 22:49 ` [PATCH 41/49] RDMA/hfi1: replace cpumask_weight with cpumask_weight_{eq, ...} where appropriate Yury Norov
2022-02-11 19:11 ` Jason Gunthorpe
2022-02-10 22:49 ` [PATCH 42/49] scsi: lpfc: replace cpumask_weight with cpumask_weight_gt Yury Norov
2022-02-10 22:49 ` [PATCH 43/49] soc/qman: replace cpumask_weight with cpumask_weight_lt Yury Norov
2022-02-10 22:49 ` [PATCH 44/49] nodemask: add nodemask_weight_{eq,gt,ge,lt,le} Yury Norov
2022-02-10 22:49 ` [PATCH 45/49] ACPI: replace nodes__weight with nodes_weight_ge for numa Yury Norov
2022-02-14 19:18 ` Rafael J. Wysocki
2022-02-14 19:34 ` Yury Norov
2022-02-14 19:45 ` Rafael J. Wysocki
2022-02-14 19:55 ` Yury Norov
2022-02-10 22:49 ` [PATCH 46/49] mm/mempolicy: replace nodes_weight with nodes_weight_eq Yury Norov
2022-02-11 10:40 ` Mike Rapoport
2022-02-11 17:44 ` Christophe JAILLET
2022-02-11 19:47 ` Yury Norov
2022-02-10 22:49 ` [PATCH 47/49] nodemask: add num_node_state_eq() Yury Norov
2022-02-11 10:41 ` Mike Rapoport
2022-02-10 22:49 ` [PATCH 48/49] tools: bitmap: sync bitmap_weight Yury Norov
2022-02-10 22:49 ` [PATCH 49/49] MAINTAINERS: add cpumask and nodemask files to BITMAP_API Yury Norov
2022-02-15 23:18 ` [PATCH v4 00/49] bitmap: optimize bitmap_weight() usage Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210224933.379149-39-yury.norov@gmail.com \
--to=yury.norov@gmail.com \
--cc=David.Laight@aculab.com \
--cc=aklimov@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=clg@kaod.org \
--cc=dennis@kernel.org \
--cc=ego@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=joe@perches.com \
--cc=john.ogness@linutronix.de \
--cc=kernel@esmil.dk \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=parth@linux.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=robh@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=sudeep.holla@arm.com \
--cc=sxwjean@gmail.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).