From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59875C433F5 for ; Sat, 12 Feb 2022 12:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235091AbiBLM50 (ORCPT ); Sat, 12 Feb 2022 07:57:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229808AbiBLM5Y (ORCPT ); Sat, 12 Feb 2022 07:57:24 -0500 Received: from mx-out.tlen.pl (mx-out.tlen.pl [193.222.135.148]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8897F26543 for ; Sat, 12 Feb 2022 04:57:18 -0800 (PST) Received: (wp-smtpd smtp.tlen.pl 21587 invoked from network); 12 Feb 2022 13:57:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=o2.pl; s=1024a; t=1644670635; bh=weZDRDI0E0hGJVcriXc1dDjTItLbxFoCkk6l2DQ179w=; h=From:To:Cc:Subject; b=fH+2S2rx5AyzhZkMZ4GlxMEoXKrsyKh6rXFaw+HId/yLvPG3k53tB//nywa9emd4V 6gvvx2rP0xTAQFhXvNkr8bnSosnEcmpOJBiDJkbxJw2fihjpLmEolN9kloeqw2Ijyg onPAUQUt0Btw6vljtr6y3krNHlfYQFY5wlWLF9NI= Received: from aaem217.neoplus.adsl.tpnet.pl (HELO localhost.localdomain) (mat.jonczyk@o2.pl@[83.4.116.217]) (envelope-sender ) by smtp.tlen.pl (WP-SMTPD) with SMTP for ; 12 Feb 2022 13:57:14 +0100 From: =?UTF-8?q?Mateusz=20Jo=C5=84czyk?= To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, platform-driver-x86@vger.kernel.org, x86@kernel.org Cc: =?UTF-8?q?Mateusz=20Jo=C5=84czyk?= , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jean Delvare , Guenter Roeck , Mark Gross , Hans de Goede , Randy Dunlap , Borislav Petkov Subject: [PATCH 1/2] x86/Kconfig: move and modify CONFIG_I8K Date: Sat, 12 Feb 2022 13:56:53 +0100 Message-Id: <20220212125654.357408-1-mat.jonczyk@o2.pl> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-WP-MailID: b265ed20f6b63aa017ad457b7a9a396d X-WP-AV: skaner antywirusowy Poczty o2 X-WP-SPAM: NO 0000001 [gTKT] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In Kconfig, inside the "Processor type and features" menu, there is the CONFIG_I8K option: "Dell i8k legacy laptop support". This is very confusing - enabling CONFIG_I8K is not required for the kernel to support old Dell laptops. This option is specific to the dell-smm-hwmon driver, which mostly exports some hardware monitoring information and allows the user to change fan speed. This option is misplaced, so move CONFIG_I8K to drivers/hwmon/Kconfig, where it belongs. Also, modify the dependency order - change select SENSORS_DELL_SMM to depends on SENSORS_DELL_SMM as it is just a configuration option of dell-smm-hwmon. This includes changing the option type from tristate to bool. It was tristate because it could select CONFIG_SENSORS_DELL_SMM=m . When running "make oldconfig" on configurations with CONFIG_SENSORS_DELL_SMM enabled , this change will result in an additional question (which could be printed several times during bisecting). I think that tidying up the configuration is worth it, though. Next patch tweaks the description of CONFIG_I8K. Signed-off-by: Mateusz Jończyk Cc: Pali Rohár Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Dave Hansen Cc: Jean Delvare Cc: Guenter Roeck Cc: Mark Gross Reviewed-by: Hans de Goede Reviewed-by: Randy Dunlap Acked-by: Borislav Petkov --- v2: - do not drop "depends on PROC_FS" from CONFIG_I8K Thanks to all for reviewing. Mr Randy Dunlap: The first patch just moves CONFIG_I8K, without modifying the help text. arch/x86/Kconfig | 17 ----------------- drivers/hwmon/Kconfig | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 9f5bd41bf660..71d4ddd48c02 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1275,23 +1275,6 @@ config TOSHIBA Say Y if you intend to run this kernel on a Toshiba portable. Say N otherwise. -config I8K - tristate "Dell i8k legacy laptop support" - depends on HWMON - depends on PROC_FS - select SENSORS_DELL_SMM - help - This option enables legacy /proc/i8k userspace interface in hwmon - dell-smm-hwmon driver. Character file /proc/i8k reports bios version, - temperature and allows controlling fan speeds of Dell laptops via - System Management Mode. For old Dell laptops (like Dell Inspiron 8000) - it reports also power and hotkey status. For fan speed control is - needed userspace package i8kutils. - - Say Y if you intend to run this kernel on old Dell laptops or want to - use userspace package i8kutils. - Say N otherwise. - config X86_REBOOTFIXUPS bool "Enable X86 board specific fixups for reboot" depends on X86_32 diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 8df25f1079ba..1ee4e5eff567 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -505,6 +505,22 @@ config SENSORS_DELL_SMM When option I8K is also enabled this driver provides legacy /proc/i8k userspace interface for i8kutils package. +config I8K + bool "Dell i8k legacy laptop support" + depends on SENSORS_DELL_SMM + depends on PROC_FS + help + This option enables legacy /proc/i8k userspace interface in hwmon + dell-smm-hwmon driver. Character file /proc/i8k reports bios version, + temperature and allows controlling fan speeds of Dell laptops via + System Management Mode. For old Dell laptops (like Dell Inspiron 8000) + it reports also power and hotkey status. For fan speed control is + needed userspace package i8kutils. + + Say Y if you intend to run this kernel on old Dell laptops or want to + use userspace package i8kutils. + Say N otherwise. + config SENSORS_DA9052_ADC tristate "Dialog DA9052/DA9053 ADC" depends on PMIC_DA9052 base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566 -- 2.25.1