From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572EAC433F5 for ; Tue, 15 Feb 2022 19:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243717AbiBOTgS (ORCPT ); Tue, 15 Feb 2022 14:36:18 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243697AbiBOTgO (ORCPT ); Tue, 15 Feb 2022 14:36:14 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2833C24A2; Tue, 15 Feb 2022 11:36:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 78E81B818F3; Tue, 15 Feb 2022 19:36:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE494C340EB; Tue, 15 Feb 2022 19:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644953761; bh=mXUYdWjAyAGnzfunbLEvRbzhk1LQeTeub57on144Gog=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AQoUEG2PH9XDgvj9VgWfsiL+cXnmIUszgtgnX63DIOexHgyIxzm547vKPwBi55Rrg PlTl+2N2Su3Hhflt3+9AF6yjE0fPI+yWtvhvMsuQxAQdq0VjXg7PF9IDrlTrGcj4fU ss1Bl+2fP8Y0FobCLBxm7cUocwNLkc39f1vA8C9TmP1+LsMwU8aGEMg95cA2R4Rplc SfFCbWyQK7eeSqhYbdqJGdqQ0qW2EbDgfB3/WGJiearA3RcOwaOLM44eHqM17duxDJ PZ8MymJ/Y7F7EZmIZSt/ANDUP9lBpgIE3HPC/cQVNPgmAe3+wvA2u0U4i2Lm7sioQp cc7rhegLmsd4A== Received: by pali.im (Postfix) id D05BCF13; Tue, 15 Feb 2022 20:35:58 +0100 (CET) Date: Tue, 15 Feb 2022 20:35:58 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Armin Wolf Cc: jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] hwmon: (dell-smm) Reword and mark parameter "force" as unsafe Message-ID: <20220215193558.rorm3vrwyxa4gkj7@pali> References: <20220215191113.16640-1-W_Armin@gmx.de> <20220215191113.16640-8-W_Armin@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220215191113.16640-8-W_Armin@gmx.de> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 15 February 2022 20:11:13 Armin Wolf wrote: > When enabling said module parameter, the driver ignores > all feature blacklists on relevant models, which has the > potential for strange side effects. Also there seems to > be a slight chance for unsupported devices to behave > badly when probed for features. > In such cases, the kernel should be tainted to inform > people that these issues might have been caused by > the dell_smm_hwmon driver with "force" enabled. > Also reword the parameter description to remind users > that enabling "force" also enables blacklisted features. > > Tested on a Dell Inspiron 3505. > > Signed-off-by: Armin Wolf Reviewed-by: Pali Rohár > --- > drivers/hwmon/dell-smm-hwmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c > index 04a41d59da60..67d63932b48a 100644 > --- a/drivers/hwmon/dell-smm-hwmon.c > +++ b/drivers/hwmon/dell-smm-hwmon.c > @@ -87,8 +87,8 @@ MODULE_LICENSE("GPL"); > MODULE_ALIAS("i8k"); > > static bool force; > -module_param(force, bool, 0); > -MODULE_PARM_DESC(force, "Force loading without checking for supported models"); > +module_param_unsafe(force, bool, 0); > +MODULE_PARM_DESC(force, "Force loading without checking for supported models and features"); > > static bool ignore_dmi; > module_param(ignore_dmi, bool, 0); > -- > 2.30.2 >