From: Jeffrey Ji <jeffreyjilinux@gmail.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Brian Vazquez <brianvv@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>,
Mahesh Bandewar <maheshb@google.com>,
jeffreyji <jeffreyji@google.com>
Subject: [PATCH v1 net-next] teaming: deliver link-local packets with the link they arrive on
Date: Tue, 15 Feb 2022 22:05:17 +0000 [thread overview]
Message-ID: <20220215220517.2498751-1-jeffreyji@google.com> (raw)
From: jeffreyji <jeffreyji@google.com>
skb is ignored if team port is disabled. We want the skb to be delivered
if it's an LLDP packet.
Issue is already fixed for bonding in commit
b89f04c61efe3b7756434d693b9203cc0cce002e
Signed-off-by: jeffreyji <jeffreyji@google.com>
---
drivers/net/team/team.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 8b2adc56b92a..24d66dfbb2e1 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -734,6 +734,12 @@ static rx_handler_result_t team_handle_frame(struct sk_buff **pskb)
port = team_port_get_rcu(skb->dev);
team = port->team;
if (!team_port_enabled(port)) {
+ if (is_link_local_ether_addr(eth_hdr(skb)->h_dest))
+ /*
+ * link-local packets are mostly useful when stack
+ * receives them with the link they arrive on.
+ */
+ return RX_HANDLER_PASS;
/* allow exact match delivery for disabled ports */
res = RX_HANDLER_EXACT;
} else {
--
2.35.1.265.g69c8d7142f-goog
next reply other threads:[~2022-02-15 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 22:05 Jeffrey Ji [this message]
2022-02-17 4:44 ` [PATCH v1 net-next] teaming: deliver link-local packets with the link they arrive on Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215220517.2498751-1-jeffreyji@google.com \
--to=jeffreyjilinux@gmail.com \
--cc=brianvv@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jeffreyji@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).