From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03F2C433EF for ; Wed, 16 Feb 2022 01:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245406AbiBPBIO (ORCPT ); Tue, 15 Feb 2022 20:08:14 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245287AbiBPBHc (ORCPT ); Tue, 15 Feb 2022 20:07:32 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5803C7916 for ; Tue, 15 Feb 2022 17:07:21 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id e3so911244wra.0 for ; Tue, 15 Feb 2022 17:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PMyMSUP7asF/s/oKu8jRzLvnYQUdmW1URZT8HnFSQy0=; b=jTJuJoASvQOgDzLtakBXSmhb4VYtpwi36BD8mZavRx52KG560ZXf8dEKL+hsksqAHK skNexb+VDcvR6BlgA8yWRO+H2u1Pq/sOl/itQHRk/I8xY2Mz6WeGDP02utMKPEVWgcsm bWKZDhDqDih2sZT1dpIzyBo7m4AUrG4wdLWTQlqHfZk1iQ5wd4o6uTdTAfk+1GkkupBa tYOxUX7tskRABT8uRquoNebIGAJX7yTOVy58vrytFhk2NTorGjRfDCXlGdnhndpqxJM1 1jqGbJpxLpxlX+hrGl4jqa1ZGnD1Nry8xO9b/oWVxh2hHEsE4Be9YZRv5Ze6Ves/CsKo ICdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PMyMSUP7asF/s/oKu8jRzLvnYQUdmW1URZT8HnFSQy0=; b=HtjbdGLvs9J9TdqvnfDgW/mihtz1EFMgpZL64MO9IwFqjZP0FLoOZ1RPY0iJHNjVpd HIUuHGUOVrtDvsT0C4yoDEuSRAHoEQk5Dq7uT5jhXLepEf81+sJo82WPd8dnOO2zbBqV A/tHnMnuACOdj1JMbhLXiO1HBZl9MzQMZ1B+A9kQesUU+liU3jSu23e8kaXP+looZevX mHQ/Tez5MP08LgnXKcy7u6WHOGJvruSUnXjII99SqWp4dohqIIS84vh7J7z54tISrSP0 e1b6Rq6trqVVVY6KyYqeSk2UUZBoep1MARL0NgbfPRfFCHdCNjyLqSOHlQji8Gzpm9j/ TzTw== X-Gm-Message-State: AOAM533pGx9xY08nQqWo13RlA79x5ELd/Az8ODTxKkjxVd8puDYtNeAK 17wI+WcdpY/PoMS8J7tz1krpaQ== X-Google-Smtp-Source: ABdhPJwKg5di3jjMCxCFW200EG/nexWDgvCjwt97MfKEHu2CrXJMwunEAx2zz3adAtk3IhDo6Bas2Q== X-Received: by 2002:a05:6000:1847:b0:1e6:2783:b3e6 with SMTP id c7-20020a056000184700b001e62783b3e6mr371068wri.163.1644973640528; Tue, 15 Feb 2022 17:07:20 -0800 (PST) Received: from localhost.localdomain (3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.6.1.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:df16::3]) by smtp.gmail.com with ESMTPSA id m8sm10551185wms.4.2022.02.15.17.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 17:07:20 -0800 (PST) From: Phillip Potter To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, Larry.Finger@lwfinger.net, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, paskripkin@gmail.com Subject: [PATCH v2 11/15] staging: r8188eu: remove rtw_debug module parameter Date: Wed, 16 Feb 2022 01:07:05 +0000 Message-Id: <20220216010709.791-12-phil@philpotter.co.uk> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220216010709.791-1-phil@philpotter.co.uk> References: <20220216010709.791-1-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove rtw_debug module parameter, and also the internal GlobalDebugLevel flag and all places where it is referenced. As hal/odm_debug.c is now essentially empty, also remove this file and edit the Makefile to no longer reference it. The DBG_88E macro was the last user of these and has now been removed, making the parameter and flag redundant. Signed-off-by: Phillip Potter --- drivers/staging/r8188eu/Makefile | 1 - drivers/staging/r8188eu/hal/odm_debug.c | 6 ------ drivers/staging/r8188eu/include/rtw_debug.h | 2 -- drivers/staging/r8188eu/os_dep/os_intfs.c | 4 ---- 4 files changed, 13 deletions(-) delete mode 100644 drivers/staging/r8188eu/hal/odm_debug.c diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile index 84627fc89ec9..1d7982b618ba 100644 --- a/drivers/staging/r8188eu/Makefile +++ b/drivers/staging/r8188eu/Makefile @@ -10,7 +10,6 @@ r8188eu-y = \ hal/hal_intf.o \ hal/hal_com.o \ hal/odm.o \ - hal/odm_debug.o \ hal/odm_HWConfig.o \ hal/odm_RegConfig8188E.o \ hal/odm_RTL8188E.o \ diff --git a/drivers/staging/r8188eu/hal/odm_debug.c b/drivers/staging/r8188eu/hal/odm_debug.c deleted file mode 100644 index 7a134229fe39..000000000000 --- a/drivers/staging/r8188eu/hal/odm_debug.c +++ /dev/null @@ -1,6 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright(c) 2007 - 2011 Realtek Corporation. */ - -#include "../include/rtw_debug.h" - -u32 GlobalDebugLevel; diff --git a/drivers/staging/r8188eu/include/rtw_debug.h b/drivers/staging/r8188eu/include/rtw_debug.h index 959fb6bd25ca..01a7d987d6cc 100644 --- a/drivers/staging/r8188eu/include/rtw_debug.h +++ b/drivers/staging/r8188eu/include/rtw_debug.h @@ -52,6 +52,4 @@ #define DRIVER_PREFIX "R8188EU: " -extern u32 GlobalDebugLevel; - #endif /* __RTW_DEBUG_H__ */ diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c index 4230819cbf8c..9884dbc6eab5 100644 --- a/drivers/staging/r8188eu/os_dep/os_intfs.c +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c @@ -45,7 +45,6 @@ static int rtw_smart_ps = 2; module_param(rtw_ips_mode, int, 0644); MODULE_PARM_DESC(rtw_ips_mode, "The default IPS mode"); -static int rtw_debug = 1; static int rtw_radio_enable = 1; static int rtw_long_retry_lmt = 7; static int rtw_short_retry_lmt = 7; @@ -148,14 +147,11 @@ MODULE_PARM_DESC(rtw_80211d, "Enable 802.11d mechanism"); static uint rtw_notch_filter = RTW_NOTCH_FILTER; module_param(rtw_notch_filter, uint, 0644); MODULE_PARM_DESC(rtw_notch_filter, "0:Disable, 1:Enable, 2:Enable only for P2P"); -module_param_named(debug, rtw_debug, int, 0444); -MODULE_PARM_DESC(debug, "Set debug level (1-9) (default 1)"); static uint loadparam(struct adapter *padapter) { struct registry_priv *registry_par = &padapter->registrypriv; - GlobalDebugLevel = rtw_debug; registry_par->chip_version = (u8)rtw_chip_version; registry_par->rfintfs = (u8)rtw_rfintfs; registry_par->lbkmode = (u8)rtw_lbkmode; -- 2.34.1