* [PATCH -next] sched/fair: clean up some inconsistent indenting
@ 2022-02-17 1:28 Yang Li
2022-02-17 14:20 ` Mel Gorman
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-02-17 1:28 UTC (permalink / raw)
To: mingo
Cc: peterz, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, bristot, linux-kernel, Yang Li, Abaci Robot
Eliminate the follow smatch warning:
kernel/sched/fair.c:5661 enqueue_task_fair() warn: inconsistent
indenting
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
kernel/sched/fair.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 28b91f11b618..1ff3f45e24f3 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5654,12 +5654,12 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
if (cfs_rq_throttled(cfs_rq))
goto enqueue_throttle;
- /*
- * One parent has been throttled and cfs_rq removed from the
- * list. Add it back to not break the leaf list.
- */
- if (throttled_hierarchy(cfs_rq))
- list_add_leaf_cfs_rq(cfs_rq);
+ /*
+ * One parent has been throttled and cfs_rq removed from the
+ * list. Add it back to not break the leaf list.
+ */
+ if (throttled_hierarchy(cfs_rq))
+ list_add_leaf_cfs_rq(cfs_rq);
}
/* At this point se is NULL and we are at root level*/
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] sched/fair: clean up some inconsistent indenting
2022-02-17 1:28 [PATCH -next] sched/fair: clean up some inconsistent indenting Yang Li
@ 2022-02-17 14:20 ` Mel Gorman
0 siblings, 0 replies; 2+ messages in thread
From: Mel Gorman @ 2022-02-17 14:20 UTC (permalink / raw)
To: Yang Li
Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, bristot, linux-kernel, Abaci Robot
On Thu, Feb 17, 2022 at 09:28:18AM +0800, Yang Li wrote:
> Eliminate the follow smatch warning:
> kernel/sched/fair.c:5661 enqueue_task_fair() warn: inconsistent
> indenting
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
This is a whitespace fix that is more appropriate if modifying the actual
code and fixing the whitspace damage at the same time. Right now, it's
more useful for git blame to point to the commits that made meaningful
changes;
39f23ce07b93 ("sched/fair: Fix unthrottle_cfs_rq() for leaf_cfs_rq list")
304000390f88 ("sched: Cgroup SCHED_IDLE support")
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-17 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-17 1:28 [PATCH -next] sched/fair: clean up some inconsistent indenting Yang Li
2022-02-17 14:20 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).