From: kernel test robot <lkp@intel.com>
To: Mans Rullgard <mans@mansr.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Juergen Borleis <kernel@pengutronix.de>,
linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: lan9303: add VLAN IDs to master device
Date: Thu, 17 Feb 2022 03:33:36 +0800 [thread overview]
Message-ID: <202202170354.djrMhJqt-lkp@intel.com> (raw)
In-Reply-To: <20220216151111.6376-1-mans@mansr.com>
Hi Mans,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc4 next-20220216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mans-Rullgard/net-dsa-lan9303-add-VLAN-IDs-to-master-device/20220216-231201
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c5d9ae265b105d9a67575fb67bd4650a6fc08e25
config: openrisc-randconfig-r004-20220216 (https://download.01.org/0day-ci/archive/20220217/202202170354.djrMhJqt-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/960beb0e82f5d219a4f7e8bdcc49fb548a82a69d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mans-Rullgard/net-dsa-lan9303-add-VLAN-IDs-to-master-device/20220216-231201
git checkout 960beb0e82f5d219a4f7e8bdcc49fb548a82a69d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/net/dsa/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/dsa/lan9303-core.c: In function 'lan9303_port_enable':
>> drivers/net/dsa/lan9303-core.c:1095:9: error: implicit declaration of function 'vlan_vid_add' [-Werror=implicit-function-declaration]
1095 | vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port);
| ^~~~~~~~~~~~
drivers/net/dsa/lan9303-core.c: In function 'lan9303_port_disable':
>> drivers/net/dsa/lan9303-core.c:1111:9: error: implicit declaration of function 'vlan_vid_del' [-Werror=implicit-function-declaration]
1111 | vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port);
| ^~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/vlan_vid_add +1095 drivers/net/dsa/lan9303-core.c
1082
1083 static int lan9303_port_enable(struct dsa_switch *ds, int port,
1084 struct phy_device *phy)
1085 {
1086 struct lan9303 *chip = ds->priv;
1087 struct dsa_port *cpu_dp;
1088
1089 if (!dsa_is_user_port(ds, port))
1090 return 0;
1091
1092 dsa_switch_for_each_cpu_port(cpu_dp, ds)
1093 break;
1094
> 1095 vlan_vid_add(cpu_dp->master, htons(ETH_P_8021Q), port);
1096
1097 return lan9303_enable_processing_port(chip, port);
1098 }
1099
1100 static void lan9303_port_disable(struct dsa_switch *ds, int port)
1101 {
1102 struct lan9303 *chip = ds->priv;
1103 struct dsa_port *cpu_dp;
1104
1105 if (!dsa_is_user_port(ds, port))
1106 return;
1107
1108 dsa_switch_for_each_cpu_port(cpu_dp, ds)
1109 break;
1110
> 1111 vlan_vid_del(cpu_dp->master, htons(ETH_P_8021Q), port);
1112
1113 lan9303_disable_processing_port(chip, port);
1114 lan9303_phy_write(ds, chip->phy_addr_base + port, MII_BMCR, BMCR_PDOWN);
1115 }
1116
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-02-16 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 15:11 [PATCH] net: dsa: lan9303: add VLAN IDs to master device Mans Rullgard
2022-02-16 15:30 ` Vladimir Oltean
2022-02-16 19:33 ` kernel test robot [this message]
2022-02-16 19:33 ` kernel test robot
2022-02-16 19:55 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202202170354.djrMhJqt-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).