From: Cristian Marussi <cristian.marussi@arm.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com,
Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com,
etienne.carriere@linaro.org, vincent.guittot@linaro.org,
souvik.chakravarty@arm.com, peter.hilber@opensynergy.com,
igor.skalkin@opensynergy.com, cristian.marussi@arm.com
Subject: [PATCH v5 7/8] firmware: arm_scmi: Add support for clock_enable_latency
Date: Thu, 17 Feb 2022 13:12:33 +0000 [thread overview]
Message-ID: <20220217131234.50328-8-cristian.marussi@arm.com> (raw)
In-Reply-To: <20220217131234.50328-1-cristian.marussi@arm.com>
An SCMI platform can optionally advertise an enable latency typically
associated with a specific clock resource: add support for parsing such
optional message field and export such information in the usual publicly
accessible clock descriptor.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
v1 --> v2
- moved enable_latency flag definition from the previous commit
v2 --> v3
- checking for clock_enable_latencty presence, removed RFC tag
---
drivers/firmware/arm_scmi/clock.c | 12 +++++++++---
include/linux/scmi_protocol.h | 1 +
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
index 72f930c0e3e2..cf6fed6dec77 100644
--- a/drivers/firmware/arm_scmi/clock.c
+++ b/drivers/firmware/arm_scmi/clock.c
@@ -27,7 +27,8 @@ struct scmi_msg_resp_clock_protocol_attributes {
struct scmi_msg_resp_clock_attributes {
__le32 attributes;
#define CLOCK_ENABLE BIT(0)
- u8 name[SCMI_MAX_STR_SIZE];
+ u8 name[SCMI_MAX_STR_SIZE];
+ __le32 clock_enable_latency;
};
struct scmi_clock_set_config {
@@ -116,10 +117,15 @@ static int scmi_clock_attributes_get(const struct scmi_protocol_handle *ph,
attr = t->rx.buf;
ret = ph->xops->do_xfer(ph, t);
- if (!ret)
+ if (!ret) {
strlcpy(clk->name, attr->name, SCMI_MAX_STR_SIZE);
- else
+ /* Is optional field clock_enable_latency provided ? */
+ if (t->rx.len == sizeof(*attr))
+ clk->enable_latency =
+ le32_to_cpu(attr->clock_enable_latency);
+ } else {
clk->name[0] = '\0';
+ }
ph->xops->xfer_put(ph, t);
return ret;
diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h
index 306e576835f8..b87551f41f9f 100644
--- a/include/linux/scmi_protocol.h
+++ b/include/linux/scmi_protocol.h
@@ -42,6 +42,7 @@ struct scmi_revision_info {
struct scmi_clock_info {
char name[SCMI_MAX_STR_SIZE];
+ unsigned int enable_latency;
bool rate_discrete;
union {
struct {
--
2.17.1
next prev parent reply other threads:[~2022-02-17 13:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 13:12 [PATCH v5 0/8] Add SCMI Virtio & Clock atomic support Cristian Marussi
2022-02-17 13:12 ` [PATCH v5 1/8] firmware: arm_scmi: Add a virtio channel refcount Cristian Marussi
2022-02-25 18:21 ` Peter Hilber
2022-02-17 13:12 ` [PATCH v5 2/8] firmware: arm_scmi: Review virtio free_list handling Cristian Marussi
2022-02-25 18:21 ` Peter Hilber
2022-02-17 13:12 ` [PATCH v5 3/8] firmware: arm_scmi: Add atomic mode support to virtio transport Cristian Marussi
2022-02-25 18:21 ` Peter Hilber
2022-02-17 13:12 ` [PATCH v5 4/8] dt-bindings: firmware: arm,scmi: Add atomic-threshold-us optional property Cristian Marussi
2022-02-17 21:34 ` Rob Herring
2022-02-17 13:12 ` [PATCH v5 5/8] firmware: arm_scmi: Support optional system wide atomic-threshold-us Cristian Marussi
2022-02-17 13:12 ` [PATCH v5 6/8] firmware: arm_scmi: Add atomic support to clock protocol Cristian Marussi
2022-02-17 13:12 ` Cristian Marussi [this message]
2022-02-17 13:12 ` [PATCH v5 8/8] clk: scmi: Support atomic clock enable/disable API Cristian Marussi
2022-02-22 12:15 ` [PATCH v5 0/8] Add SCMI Virtio & Clock atomic support Sudeep Holla
2022-03-04 16:13 ` Michael S. Tsirkin
2022-03-04 16:41 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217131234.50328-8-cristian.marussi@arm.com \
--to=cristian.marussi@arm.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=etienne.carriere@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=igor.skalkin@opensynergy.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hilber@opensynergy.com \
--cc=souvik.chakravarty@arm.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).