Re: [PATCH 3/4] hwmon: (occ) Add sysfs entries for additional extended status bits

From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	jdelvare@suse.com, joel@jms.id.au
Subject: Re: [PATCH 3/4] hwmon: (occ) Add sysfs entries for additional extended status bits
Date: Sat, 19 Feb 2022 06:37:24 -0800	[thread overview]
Message-ID: <20220219143724.GA1031933@roeck-us.net> (raw)
In-Reply-To: <20220215151022.7498-4-eajames@linux.ibm.com>

On Tue, Feb 15, 2022 at 09:10:21AM -0600, Eddie James wrote:
> Add sysfs entries for DVFS due to a VRM Vdd over-temperature condition,
> and add the GPU throttling condition bits (such that if bit 1 is set,
> GPU1 is throttling).
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Reviewed-by: Joel Stanley <joel@jms.id.au>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/occ/sysfs.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/hwmon/occ/sysfs.c b/drivers/hwmon/occ/sysfs.c
> index 88f655887c95..b2f788a77746 100644
> --- a/drivers/hwmon/occ/sysfs.c
> +++ b/drivers/hwmon/occ/sysfs.c
> @@ -19,6 +19,8 @@
>  #define OCC_EXT_STAT_DVFS_POWER		BIT(6)
>  #define OCC_EXT_STAT_MEM_THROTTLE	BIT(5)
>  #define OCC_EXT_STAT_QUICK_DROP		BIT(4)
> +#define OCC_EXT_STAT_DVFS_VDD		BIT(3)
> +#define OCC_EXT_STAT_GPU_THROTTLE	GENMASK(2, 0)
>  
>  static ssize_t occ_sysfs_show(struct device *dev,
>  			      struct device_attribute *attr, char *buf)
> @@ -69,6 +71,12 @@ static ssize_t occ_sysfs_show(struct device *dev,
>  	case 9:
>  		val = header->mode;
>  		break;
> +	case 10:
> +		val = !!(header->ext_status & OCC_EXT_STAT_DVFS_VDD);
> +		break;
> +	case 11:
> +		val = header->ext_status & OCC_EXT_STAT_GPU_THROTTLE;
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
> @@ -96,6 +104,8 @@ static SENSOR_DEVICE_ATTR(occ_state, 0444, occ_sysfs_show, NULL, 6);
>  static SENSOR_DEVICE_ATTR(occs_present, 0444, occ_sysfs_show, NULL, 7);
>  static SENSOR_DEVICE_ATTR(occ_ips_status, 0444, occ_sysfs_show, NULL, 8);
>  static SENSOR_DEVICE_ATTR(occ_mode, 0444, occ_sysfs_show, NULL, 9);
> +static SENSOR_DEVICE_ATTR(occ_dvfs_vdd, 0444, occ_sysfs_show, NULL, 10);
> +static SENSOR_DEVICE_ATTR(occ_gpu_throttle, 0444, occ_sysfs_show, NULL, 11);
>  static DEVICE_ATTR_RO(occ_error);
>  
>  static struct attribute *occ_attributes[] = {
> @@ -109,6 +119,8 @@ static struct attribute *occ_attributes[] = {
>  	&sensor_dev_attr_occs_present.dev_attr.attr,
>  	&sensor_dev_attr_occ_ips_status.dev_attr.attr,
>  	&sensor_dev_attr_occ_mode.dev_attr.attr,
> +	&sensor_dev_attr_occ_dvfs_vdd.dev_attr.attr,
> +	&sensor_dev_attr_occ_gpu_throttle.dev_attr.attr,
>  	&dev_attr_occ_error.attr,
>  	NULL
>  };
> @@ -166,6 +178,18 @@ void occ_sysfs_poll_done(struct occ *occ)
>  		sysfs_notify(&occ->bus_dev->kobj, NULL, name);
>  	}
>  
> +	if ((header->ext_status & OCC_EXT_STAT_DVFS_VDD) !=
> +	    (occ->prev_ext_stat & OCC_EXT_STAT_DVFS_VDD)) {
> +		name = sensor_dev_attr_occ_dvfs_vdd.dev_attr.attr.name;
> +		sysfs_notify(&occ->bus_dev->kobj, NULL, name);
> +	}
> +
> +	if ((header->ext_status & OCC_EXT_STAT_GPU_THROTTLE) !=
> +	    (occ->prev_ext_stat & OCC_EXT_STAT_GPU_THROTTLE)) {
> +		name = sensor_dev_attr_occ_gpu_throttle.dev_attr.attr.name;
> +		sysfs_notify(&occ->bus_dev->kobj, NULL, name);
> +	}
> +
>  	if ((header->status & OCC_STAT_MASTER) &&
>  	    header->occs_present != occ->prev_occs_present) {
>  		name = sensor_dev_attr_occs_present.dev_attr.attr.name;