* [PATCH] lib/iov_iter: initialize "flags" in new pipe_buffer
@ 2022-02-21 10:03 Max Kellermann
2022-02-21 15:18 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Max Kellermann @ 2022-02-21 10:03 UTC (permalink / raw)
To: linux-kernel, viro, linux-fsdevel; +Cc: Max Kellermann, stable
The functions copy_page_to_iter_pipe() and push_pipe() can both
allocate a new pipe_buffer, but the "flags" member initializer is
missing.
Fixes: 241699cd72a8 ("new iov_iter flavour: pipe-backed")
To: Alexander Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
To: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
lib/iov_iter.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index b0e0acdf96c1..6dd5330f7a99 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -414,6 +414,7 @@ static size_t copy_page_to_iter_pipe(struct page *page, size_t offset, size_t by
return 0;
buf->ops = &page_cache_pipe_buf_ops;
+ buf->flags = 0;
get_page(page);
buf->page = page;
buf->offset = offset;
@@ -577,6 +578,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size,
break;
buf->ops = &default_pipe_buf_ops;
+ buf->flags = 0;
buf->page = page;
buf->offset = 0;
buf->len = min_t(ssize_t, left, PAGE_SIZE);
--
2.34.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib/iov_iter: initialize "flags" in new pipe_buffer
2022-02-21 10:03 [PATCH] lib/iov_iter: initialize "flags" in new pipe_buffer Max Kellermann
@ 2022-02-21 15:18 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2022-02-21 15:18 UTC (permalink / raw)
To: Max Kellermann; +Cc: linux-kernel, linux-fsdevel, stable
On Mon, Feb 21, 2022 at 11:03:13AM +0100, Max Kellermann wrote:
> The functions copy_page_to_iter_pipe() and push_pipe() can both
> allocate a new pipe_buffer, but the "flags" member initializer is
> missing.
>
> Fixes: 241699cd72a8 ("new iov_iter flavour: pipe-backed")
> To: Alexander Viro <viro@zeniv.linux.org.uk>
> To: linux-fsdevel@vger.kernel.org
> To: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Applied, will push to Linus...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-21 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 10:03 [PATCH] lib/iov_iter: initialize "flags" in new pipe_buffer Max Kellermann
2022-02-21 15:18 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).