From: Jagath Jog J <jagathjog1996@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, andy.shevchenko@gmail.com,
sst@poczta.fm, robh+dt@kernel.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 5/7] iio: potentiometer: Add device specific read_raw function
Date: Wed, 23 Feb 2022 22:05:23 +0530 [thread overview]
Message-ID: <20220223163525.13399-6-jagathjog1996@gmail.com> (raw)
In-Reply-To: <20220223163525.13399-1-jagathjog1996@gmail.com>
Added function pointer in the device specific structure to
call the appropriate device read_raw function, so that the
other type of devices with different read method can be
handled.
Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
---
drivers/iio/potentiometer/ds1803.c | 28 ++++++++++++++++++++++------
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/potentiometer/ds1803.c b/drivers/iio/potentiometer/ds1803.c
index aeb74ee46fbc..878188351f8f 100644
--- a/drivers/iio/potentiometer/ds1803.c
+++ b/drivers/iio/potentiometer/ds1803.c
@@ -32,6 +32,8 @@ struct ds1803_cfg {
int kohms;
const struct iio_chan_spec *channels;
u8 num_channels;
+ int (*read)(struct iio_dev *indio_dev,
+ struct iio_chan_spec const *chan, int *val);
};
struct ds1803_data {
@@ -55,6 +57,22 @@ static const struct iio_chan_spec ds1803_channels[] = {
DS1803_CHANNEL(1, DS1803_WIPER_1),
};
+static int ds1803_read(struct iio_dev *indio_dev,
+ struct iio_chan_spec const *chan,
+ int *val)
+{
+ struct ds1803_data *data = iio_priv(indio_dev);
+ int ret;
+ u8 result[ARRAY_SIZE(ds1803_channels)];
+
+ ret = i2c_master_recv(data->client, result, indio_dev->num_channels);
+ if (ret < 0)
+ return ret;
+
+ *val = result[chan->channel];
+ return ret;
+}
+
static const struct ds1803_cfg ds1803_cfg[] = {
[DS1803_010] = {
.wipers = 2,
@@ -62,6 +80,7 @@ static const struct ds1803_cfg ds1803_cfg[] = {
.kohms = 10,
.channels = ds1803_channels,
.num_channels = ARRAY_SIZE(ds1803_channels),
+ .read = ds1803_read,
},
[DS1803_050] = {
.wipers = 2,
@@ -69,6 +88,7 @@ static const struct ds1803_cfg ds1803_cfg[] = {
.kohms = 50,
.channels = ds1803_channels,
.num_channels = ARRAY_SIZE(ds1803_channels),
+ .read = ds1803_read,
},
[DS1803_100] = {
.wipers = 2,
@@ -76,6 +96,7 @@ static const struct ds1803_cfg ds1803_cfg[] = {
.kohms = 100,
.channels = ds1803_channels,
.num_channels = ARRAY_SIZE(ds1803_channels),
+ .read = ds1803_read,
},
};
@@ -84,20 +105,15 @@ static int ds1803_read_raw(struct iio_dev *indio_dev,
int *val, int *val2, long mask)
{
struct ds1803_data *data = iio_priv(indio_dev);
- int pot = chan->channel;
int ret;
- u8 result[ARRAY_SIZE(ds1803_channels)];
switch (mask) {
case IIO_CHAN_INFO_RAW:
- ret = i2c_master_recv(data->client, result,
- indio_dev->num_channels);
+ ret = data->cfg->read(indio_dev, chan, val);
if (ret < 0)
return ret;
- *val = result[pot];
return IIO_VAL_INT;
-
case IIO_CHAN_INFO_SCALE:
*val = 1000 * data->cfg->kohms;
*val2 = data->cfg->avail[2]; /* Max wiper position */
--
2.17.1
next prev parent reply other threads:[~2022-02-23 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 16:35 [PATCH v5 0/7] iio: potentiometer: Add support for DS3502 Jagath Jog J
2022-02-23 16:35 ` [PATCH v5 1/7] iio: potentiometer: Alignment to match the open parenthesis Jagath Jog J
2022-02-26 18:35 ` Jonathan Cameron
2022-02-23 16:35 ` [PATCH v5 2/7] iio: potentiometer: Add available functionality Jagath Jog J
2022-02-26 18:40 ` Jonathan Cameron
2022-02-23 16:35 ` [PATCH v5 3/7] iio: potentiometer: Add channel information in device data Jagath Jog J
2022-02-23 16:35 ` [PATCH v5 4/7] iio: potentiometer: Change to firmware provided data Jagath Jog J
2022-02-23 16:35 ` Jagath Jog J [this message]
2022-02-24 0:46 ` [PATCH v5 5/7] iio: potentiometer: Add device specific read_raw function Andy Shevchenko
2022-02-26 18:39 ` Jonathan Cameron
2022-02-23 16:35 ` [PATCH v5 6/7] iio: potentiometer: Add support for Maxim DS3502 Jagath Jog J
2022-02-23 16:35 ` [PATCH v5 7/7] dt-bindings: iio: potentiometer: Add Maxim DS3502 in trivial-devices Jagath Jog J
2022-02-24 0:47 ` [PATCH v5 0/7] iio: potentiometer: Add support for DS3502 Andy Shevchenko
2022-02-26 18:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223163525.13399-6-jagathjog1996@gmail.com \
--to=jagathjog1996@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).