From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161C8C4332F for ; Wed, 23 Feb 2022 17:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243204AbiBWRG1 (ORCPT ); Wed, 23 Feb 2022 12:06:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243188AbiBWRGY (ORCPT ); Wed, 23 Feb 2022 12:06:24 -0500 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79DB55372C; Wed, 23 Feb 2022 09:05:56 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 14AB31C000A; Wed, 23 Feb 2022 17:05:52 +0000 (UTC) Date: Wed, 23 Feb 2022 18:05:51 +0100 From: Jacopo Mondi To: Eugen Hristev Cc: linux-media@vger.kernel.org, hverkuil-cisco@xs4all.nl, nicolas.ferre@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, claudiu.beznea@microchip.com, Hans Verkuil Subject: Re: [PATCH v5 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Message-ID: <20220223170551.6wbehkwjsddfzg5h@uno.localdomain> References: <20220217135645.1427466-1-eugen.hristev@microchip.com> <20220217135645.1427466-3-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220217135645.1427466-3-eugen.hristev@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eugen On Thu, Feb 17, 2022 at 03:56:34PM +0200, Eugen Hristev wrote: > In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY, > not check if it's streaming to return the busy state. > > Suggested-by: Hans Verkuil > Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/media/platform/atmel/atmel-isc-base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c > index d2cc6c99984f..67b4a2323fed 100644 > --- a/drivers/media/platform/atmel/atmel-isc-base.c > +++ b/drivers/media/platform/atmel/atmel-isc-base.c > @@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv, > { > struct isc_device *isc = video_drvdata(file); > > - if (vb2_is_streaming(&isc->vb2_vidq)) > + if (vb2_is_busy(&isc->vb2_vidq)) > return -EBUSY; > > return isc_set_fmt(isc, f); > -- > 2.25.1 >