From: Jacopo Mondi <jacopo@jmondi.org>
To: Eugen Hristev <eugen.hristev@microchip.com>
Cc: linux-media@vger.kernel.org, hverkuil-cisco@xs4all.nl,
nicolas.ferre@microchip.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
claudiu.beznea@microchip.com
Subject: Re: [PATCH v5 05/13] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check
Date: Wed, 23 Feb 2022 18:06:53 +0100 [thread overview]
Message-ID: <20220223170653.z5frqap4wsvi3lsu@uno.localdomain> (raw)
In-Reply-To: <20220217135645.1427466-6-eugen.hristev@microchip.com>
Hi Eugen
On Thu, Feb 17, 2022 at 03:56:37PM +0200, Eugen Hristev wrote:
> While this does not happen in production, this check should be done
> versus the mask, as checking with the YCYC value may not include
> some bits that may be set.
> Is it correct and safe to check the whole mask.
>
> Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
I trust this
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
> ---
> drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> index c244682ea22f..025c3e8a7e95 100644
> --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
> @@ -291,7 +291,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc)
> * Thus, if the YCYC mode is selected, replace it with the
> * sama5d2-compliant mode which is YYCC .
> */
> - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) {
> + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) {
> rlp_mode &= ~ISC_RLP_CFG_MODE_MASK;
> rlp_mode |= ISC_RLP_CFG_MODE_YYCC;
> }
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-02-23 17:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 13:56 [PATCH v5 00/13] media: atmel: atmel-isc: implement media controller Eugen Hristev
2022-02-17 13:56 ` [PATCH v5 01/13] media: atmel: atmel-isc-base: use streaming status when queueing buffers Eugen Hristev
2022-02-23 17:05 ` Jacopo Mondi
2022-02-17 13:56 ` [PATCH v5 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Eugen Hristev
2022-02-23 17:05 ` Jacopo Mondi
2022-02-17 13:56 ` [PATCH v5 03/13] media: atmel: atmel-isc: remove redundant comments Eugen Hristev
2022-02-23 17:06 ` Jacopo Mondi
2022-02-17 13:56 ` [PATCH v5 04/13] media: atmel: atmel-isc: implement media controller Eugen Hristev
2022-02-17 14:59 ` Eugen.Hristev
2022-02-23 16:34 ` Jacopo Mondi
2022-02-23 16:32 ` Jacopo Mondi
2022-03-01 8:56 ` Eugen.Hristev
2022-02-17 13:56 ` [PATCH v5 05/13] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Eugen Hristev
2022-02-23 17:06 ` Jacopo Mondi [this message]
2022-02-17 13:56 ` [PATCH v5 06/13] media: atmel: atmel-isc-base: use mutex to lock awb workqueue from streaming Eugen Hristev
2022-02-23 17:07 ` Jacopo Mondi
2022-02-17 13:56 ` [PATCH v5 07/13] media: atmel: atmel-isc: compact the controller formats list Eugen Hristev
2022-02-17 13:56 ` [PATCH v5 08/13] media: atmel: atmel-isc: change format propagation to subdev into only verification Eugen Hristev
2022-02-23 17:03 ` Jacopo Mondi
2022-03-03 15:21 ` Eugen.Hristev
2022-02-17 13:56 ` [PATCH v5 09/13] media: atmel: atmel-sama7g5-isc: remove stray line Eugen Hristev
2022-02-23 17:07 ` Jacopo Mondi
2022-02-17 13:56 ` [PATCH v5 10/13] dt-bindings: media: microchip,xisc: add bus-width of 14 Eugen Hristev
2022-02-17 13:56 ` [PATCH v5 11/13] ARM: dts: at91: sama7g5: add nodes for video capture Eugen Hristev
2022-02-17 13:56 ` [PATCH v5 12/13] ARM: configs: at91: sama7: add xisc and csi2dc Eugen Hristev
2022-02-17 13:56 ` [PATCH v5 13/13] ARM: multi_v7_defconfig: add atmel video pipeline modules Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223170653.z5frqap4wsvi3lsu@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).