From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Anders Roxell <anders.roxell@linaro.org>,
mpe@ellerman.id.au, stable@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/3] powerpc: fix build errors
Date: Thu, 24 Feb 2022 11:12:07 -0600 [thread overview]
Message-ID: <20220224171207.GM614@gate.crashing.org> (raw)
In-Reply-To: <1645678884.dsm10mudmp.astroid@bobo.none>
On Thu, Feb 24, 2022 at 03:05:28PM +1000, Nicholas Piggin wrote:
> + * gcc 10 started to emit a .machine directive at the beginning of generated
> + * .s files, which overrides assembler -Wa,-m<cpu> options passed down.
> + * Unclear if this behaviour will be reverted.
It will not be reverted. If you need a certain .machine for some asm
code, you should write just that!
> +#ifdef CONFIG_CC_IS_GCC
> +#if (GCC_VERSION >= 100000)
> +#if (CONFIG_AS_VERSION == 23800)
> +asm(".machine any");
> +#endif
> +#endif
> +#endif
> +#endif /* __ASSEMBLY__ */
Abusing toplevel asm like this is broken and you *will* end up with
unhappiness all around.
Segher
next prev parent reply other threads:[~2022-02-24 17:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:58 [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Anders Roxell
2022-02-23 13:58 ` [PATCH 2/3] powerpc: fix build errors Anders Roxell
2022-02-23 15:21 ` Segher Boessenkool
2022-02-24 2:54 ` Nicholas Piggin
2022-02-24 5:05 ` Nicholas Piggin
2022-02-24 8:55 ` Arnd Bergmann
2022-02-24 10:11 ` Nicholas Piggin
2022-02-24 10:20 ` Arnd Bergmann
2022-02-24 11:13 ` Nicholas Piggin
2022-02-24 17:29 ` Segher Boessenkool
2022-02-25 0:23 ` Nicholas Piggin
2022-02-25 22:28 ` Segher Boessenkool
2022-02-26 0:07 ` Nicholas Piggin
2022-02-24 17:12 ` Segher Boessenkool [this message]
2022-02-25 0:32 ` Nicholas Piggin
2022-02-25 8:33 ` Arnd Bergmann
2022-02-25 10:51 ` Nicholas Piggin
2022-02-25 22:33 ` Segher Boessenkool
2022-02-24 12:39 ` Michael Ellerman
2022-02-24 16:12 ` Anders Roxell
2022-02-24 17:37 ` Segher Boessenkool
2022-02-23 13:58 ` [PATCH 3/3] powerpc: lib: sstep: " Anders Roxell
2022-02-23 15:27 ` Segher Boessenkool
2022-02-24 2:40 ` [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224171207.GM614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).