linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
	<linux-ide@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>, <hdegoede@redhat.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [RFC 2/2] ata: ahci: Protect users from setting policies their drives don't support
Date: Fri, 25 Feb 2022 12:10:30 -0600	[thread overview]
Message-ID: <20220225181030.980223-2-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220225181030.980223-1-mario.limonciello@amd.com>

As the default low power policy applies to more chipsets and drives, it's
important to make sure that drives actually support the policy that a user
selected in their kernel configuration.

If the drive doesn't support slumber, don't let the default policy for the
ATA port be `min_power` or `min_power_with_partial`.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/ata/ahci.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 17d757ad7111..af8999453084 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1584,8 +1584,16 @@ static int ahci_init_msi(struct pci_dev *pdev, unsigned int n_ports,
 static void ahci_update_initial_lpm_policy(struct ata_port *ap,
 					   struct ahci_host_priv *hpriv)
 {
+	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
 	int policy = CONFIG_SATA_LPM_POLICY;
 
+	if (policy >= ATA_LPM_MIN_POWER_WITH_PARTIAL &&
+	   !(hpriv->cap & HOST_CAP_SSC)) {
+		dev_warn(&pdev->dev,
+			 "This drive doesn't support slumber; ignoring default SATA policy\n");
+		return;
+	}
+
 	/* user modified policy via module param */
 	if (mobile_lpm_policy != -1) {
 		policy = mobile_lpm_policy;
-- 
2.34.1


  reply	other threads:[~2022-02-25 18:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 18:10 [RFC 1/2] ata: ahci: Drop low power policy board type Mario Limonciello
2022-02-25 18:10 ` Mario Limonciello [this message]
2022-02-25 21:20   ` [RFC 2/2] ata: ahci: Protect users from setting policies their drives don't support Hans de Goede
2022-02-25 21:24     ` Limonciello, Mario
2022-02-26 11:23       ` Hans de Goede
2022-02-25 21:13 ` [RFC 1/2] ata: ahci: Drop low power policy board type Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225181030.980223-2-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).