From: Andrew Morton <akpm@linux-foundation.org>
To: "NeilBrown" <neilb@suse.de>
Cc: "Jan Kara" <jack@suse.cz>,
"Wu Fengguang" <fengguang.wu@intel.com>,
"Jaegeuk Kim" <jaegeuk@kernel.org>, "Chao Yu" <chao@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna.schumaker@netapp.com>,
"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
"Darrick J. Wong" <djwong@kernel.org>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Paolo Valente" <paolo.valente@linaro.org>,
"Jens Axboe" <axboe@kernel.dk>,
linux-doc@vger.kernel.org, linux-mm@kvack.org,
linux-nilfs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, ceph-devel@vger.kernel.org,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 02/11] MM: document and polish read-ahead code.
Date: Sun, 27 Feb 2022 20:47:28 -0800 [thread overview]
Message-ID: <20220227204728.b2eb5dd94ecc3e86912bacad@linux-foundation.org> (raw)
In-Reply-To: <164602251992.20161.9146570952337454229@noble.neil.brown.name>
On Mon, 28 Feb 2022 15:28:39 +1100 "NeilBrown" <neilb@suse.de> wrote:
> When writing documentation the intent of the author is of some interest,
> but the behaviour of the code is paramount.
uh, er, ah, no. The code describes the behaviour of the code. The
comments are there to describe things other than the code's behaviour.
Things such as the author's intent.
Any deviation between the author's intent and the code's behaviour is
called a "bug", so it's pretty important to understand authorial
intent, no?
next prev parent reply other threads:[~2022-02-28 4:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 5:37 [PATCH 00/11] Remove remaining parts of congestion tracking code NeilBrown
2022-02-10 5:37 ` [PATCH 07/11] Remove inode_congested() NeilBrown
2022-02-10 5:37 ` [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC" NeilBrown
2022-02-10 10:02 ` Jan Kara
2022-02-10 5:37 ` [PATCH 02/11] MM: document and polish read-ahead code NeilBrown
2022-02-10 12:24 ` Jan Kara
2022-02-10 23:35 ` NeilBrown
2022-02-24 18:26 ` Jan Kara
2022-02-28 4:28 ` NeilBrown
2022-02-28 4:47 ` Andrew Morton [this message]
2022-02-28 5:19 ` NeilBrown
2022-02-10 5:37 ` [PATCH 05/11] nfs: remove reliance on bdi congestion NeilBrown
2022-02-10 5:37 ` [PATCH 08/11] Remove bdi_congested() and wb_congested() and related functions NeilBrown
2022-02-24 18:10 ` Ryusuke Konishi
2022-02-10 5:37 ` [PATCH 06/11] ceph: remove reliance on bdi congestion NeilBrown
2022-02-10 5:37 ` [PATCH 04/11] fuse: " NeilBrown
2022-02-10 5:37 ` [PATCH 03/11] MM: improve cleanup when ->readpages doesn't process all pages NeilBrown
2022-02-10 5:37 ` [PATCH 09/11] f2fs: replace congestion_wait() calls with io_schedule_timeout() NeilBrown
2022-02-10 5:37 ` [PATCH 01/11] DOC: convert 'subsection' to 'section' in gfp.h NeilBrown
2022-02-10 5:37 ` [PATCH 11/11] Remove congestion tracking framework NeilBrown
2022-02-22 3:17 [PATCH 00/11] Remove remaining parts of congestion tracking code NeilBrown
2022-02-22 3:17 ` [PATCH 02/11] MM: document and polish read-ahead code NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220227204728.b2eb5dd94ecc3e86912bacad@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=drbd-dev@lists.linbit.com \
--cc=fengguang.wu@intel.com \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=konishi.ryusuke@gmail.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=paolo.valente@linaro.org \
--cc=philipp.reisner@linbit.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).