From: Muchun Song <songmuchun@bytedance.com>
To: dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
apopple@nvidia.com, shy828301@gmail.com, rcampbell@nvidia.com,
hughd@google.com, xiyuyang19@fudan.edu.cn,
kirill.shutemov@linux.intel.com, zwisler@kernel.org,
hch@infradead.org
Cc: linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
duanxiongchun@bytedance.com, smuchun@gmail.com,
Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH v3 2/6] dax: fix cache flush on PMD-mapped pages
Date: Mon, 28 Feb 2022 14:35:32 +0800 [thread overview]
Message-ID: <20220228063536.24911-3-songmuchun@bytedance.com> (raw)
In-Reply-To: <20220228063536.24911-1-songmuchun@bytedance.com>
The flush_cache_page() only remove a PAGE_SIZE sized range from the cache.
However, it does not cover the full pages in a THP except a head page.
Replace it with flush_cache_range() to fix this issue.
Fixes: f729c8c9b24f ("dax: wrprotect pmd_t in dax_mapping_entry_mkclean")
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
fs/dax.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/dax.c b/fs/dax.c
index 67a08a32fccb..a372304c9695 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -845,7 +845,8 @@ static void dax_entry_mkclean(struct address_space *mapping, pgoff_t index,
if (!pmd_dirty(*pmdp) && !pmd_write(*pmdp))
goto unlock_pmd;
- flush_cache_page(vma, address, pfn);
+ flush_cache_range(vma, address,
+ address + HPAGE_PMD_SIZE);
pmd = pmdp_invalidate(vma, address, pmdp);
pmd = pmd_wrprotect(pmd);
pmd = pmd_mkclean(pmd);
--
2.11.0
next prev parent reply other threads:[~2022-02-28 6:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 6:35 [PATCH v3 0/6] Fix some bugs related to ramp and dax Muchun Song
2022-02-28 6:35 ` [PATCH v3 1/6] mm: rmap: fix cache flush on THP pages Muchun Song
2022-02-28 6:35 ` Muchun Song [this message]
2022-02-28 6:35 ` [PATCH v3 3/6] mm: rmap: introduce pfn_mkclean_range() to cleans PTEs Muchun Song
2022-02-28 6:35 ` [PATCH v3 4/6] mm: pvmw: add support for walking devmap pages Muchun Song
2022-02-28 17:35 ` kernel test robot
2022-02-28 21:26 ` Andrew Morton
2022-03-01 3:14 ` Muchun Song
2022-02-28 6:35 ` [PATCH v3 5/6] dax: fix missing writeprotect the pte entry Muchun Song
2022-02-28 6:35 ` [PATCH v3 6/6] mm: remove range parameter from follow_invalidate_pte() Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228063536.24911-3-songmuchun@bytedance.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=duanxiongchun@bytedance.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=rcampbell@nvidia.com \
--cc=shy828301@gmail.com \
--cc=smuchun@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).