From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: <lgirdwood@gmail.com>, <broonie@kernel.org>
Cc: <kernel@axis.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Vincent Whitchurch <vincent.whitchurch@axis.com>
Subject: [PATCH v2 2/3] regulator: virtual: warn against production use
Date: Tue, 1 Mar 2022 12:18:30 +0100 [thread overview]
Message-ID: <20220301111831.3742383-3-vincent.whitchurch@axis.com> (raw)
In-Reply-To: <20220301111831.3742383-1-vincent.whitchurch@axis.com>
This driver is only meant for debugging and testing. Currently, it's
not possible to use it without patching the kernel since it requires
platform data, but we'll be adding devicetree support, so add a loud
warning to make it clear that it's still only meant for debugging and
testing.
Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
---
drivers/regulator/virtual.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c
index 50d2e9caaa71..9e0abbee1df5 100644
--- a/drivers/regulator/virtual.c
+++ b/drivers/regulator/virtual.c
@@ -285,8 +285,21 @@ static int regulator_virtual_probe(struct platform_device *pdev)
{
char *reg_id = dev_get_platdata(&pdev->dev);
struct virtual_consumer_data *drvdata;
+ static bool warned;
int ret;
+ if (!warned) {
+ warned = true;
+ pr_warn("**********************************************************\n");
+ pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
+ pr_warn("** **\n");
+ pr_warn("** regulator-virtual-consumer is only for testing and **\n");
+ pr_warn("** debugging. Do not use it in a production kernel. **\n");
+ pr_warn("** **\n");
+ pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n");
+ pr_warn("**********************************************************\n");
+ }
+
drvdata = devm_kzalloc(&pdev->dev, sizeof(struct virtual_consumer_data),
GFP_KERNEL);
if (drvdata == NULL)
--
2.34.1
next prev parent reply other threads:[~2022-03-01 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 11:18 [PATCH v2 0/3] Devicetree support for regulator-virtual-consumer Vincent Whitchurch
2022-03-01 11:18 ` [PATCH v2 1/3] regulator: virtual: use dev_err_probe() Vincent Whitchurch
2022-03-01 11:18 ` Vincent Whitchurch [this message]
2022-03-01 11:18 ` [PATCH v2 3/3] regulator: virtual: add devicetree support Vincent Whitchurch
2022-03-02 17:01 ` [PATCH v2 0/3] Devicetree support for regulator-virtual-consumer Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301111831.3742383-3-vincent.whitchurch@axis.com \
--to=vincent.whitchurch@axis.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).