From: Ioana Ciornei <ioana.ciornei@nxp.com>
To: Yeqi Fu <fufuyqqqqqq@gmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yongzhi Liu <lyz_cs@pku.edu.cn>
Subject: Re: [PATCH v1] dpaa2-switch: fix memory leak of dpaa2_switch_acl_entry_add
Date: Tue, 1 Mar 2022 17:03:00 +0000 [thread overview]
Message-ID: <20220301170259.zvcriwpmz2j73gyi@skbuf> (raw)
In-Reply-To: <20220301141544.13411-1-fufuyqqqqqq@gmail.com>
On Tue, Mar 01, 2022 at 10:15:44PM +0800, Yeqi Fu wrote:
> The error handling branch did not properly free the memory of cmd_buf
> before return, which would cause memory leak. So fix this by adding
> kfree to the error handling branch.
>
> Fixes: 1110318d83e8 ("dpaa2-switch: add tc flower hardware offload on ingress traffic")
> Signed-off-by: Yeqi Fu <fufuyqqqqqq@gmail.com>
> Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Just as a note, this should have been [PATCH v2] and not v1.
Ioana
next prev parent reply other threads:[~2022-03-01 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 9:34 [PATCH] dpaa2 ethernet switch driver: Fix memory leak in dpaa2_switch_acl_entry_add() Q1IQ
2022-03-01 12:14 ` Denis Kirjanov
2022-03-01 14:15 ` [PATCH v1] dpaa2-switch: fix memory leak of dpaa2_switch_acl_entry_add Yeqi Fu
2022-03-01 17:03 ` Ioana Ciornei [this message]
2022-03-02 1:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301170259.zvcriwpmz2j73gyi@skbuf \
--to=ioana.ciornei@nxp.com \
--cc=davem@davemloft.net \
--cc=fufuyqqqqqq@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyz_cs@pku.edu.cn \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).