From: Daniel Thompson <daniel.thompson@linaro.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: mcgrof@kernel.org, christophe.leroy@csgroup.eu, pmladek@suse.com,
cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org,
jeyu@kernel.org, linux-kernel@vger.kernel.org,
linux-modules@vger.kernel.org, void@manifault.com,
atomlin@atomlin.com, allen.lkml@gmail.com, joe@perches.com,
msuchanek@suse.de, oleksandr@natalenko.name,
jason.wessel@windriver.com
Subject: Re: [PATCH v9 13/14] module: Move kdb_modules list out of core code
Date: Wed, 2 Mar 2022 16:19:17 +0000 [thread overview]
Message-ID: <20220302161917.gx5icfszakoye4uh@maple.lan> (raw)
In-Reply-To: <20220228234322.2073104-14-atomlin@redhat.com>
On Mon, Feb 28, 2022 at 11:43:21PM +0000, Aaron Tomlin wrote:
> No functional change.
>
> This patch migrates kdb_modules list to core kdb code
> since the list of added/or loaded modules is no longer
> private.
>
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
> ---
> kernel/debug/kdb/kdb_main.c | 5 +++++
> kernel/debug/kdb/kdb_private.h | 4 ----
> kernel/module/main.c | 4 ----
> 3 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
> index 0852a537dad4..5369bf45c5d4 100644
> --- a/kernel/debug/kdb/kdb_main.c
> +++ b/kernel/debug/kdb/kdb_main.c
> @@ -59,6 +59,11 @@ EXPORT_SYMBOL(kdb_grepping_flag);
> int kdb_grep_leading;
> int kdb_grep_trailing;
>
> +#ifdef CONFIG_MODULES
> +extern struct list_head modules;
> +static struct list_head *kdb_modules = &modules; /* kdb needs the list of modules */
If modules is no longer static then why do we kdb_modules at all?
kdb_modules is used exactly once and it can now simply be replaced
with &modules.
Daniel.
next prev parent reply other threads:[~2022-03-02 16:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 23:43 [PATCH v9 00/14] module: core code clean up Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 01/14] module: Move all into module/ Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 02/14] module: Simple refactor in preparation for split Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 03/14] module: Make internal.h and decompress.c more compliant Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 04/14] module: Move livepatch support to a separate file Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 05/14] module: Move latched RB-tree " Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 06/14] module: Move strict rwx " Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 07/14] module: Move extra signature support out of core code Aaron Tomlin
2022-03-02 8:08 ` Christophe Leroy
2022-03-02 13:33 ` Aaron Tomlin
2022-03-02 13:41 ` Christophe Leroy
2022-03-05 20:37 ` Aaron Tomlin
2022-03-06 17:46 ` Christophe Leroy
2022-03-07 9:38 ` Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 08/14] module: Move kmemleak support to a separate file Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 09/14] module: Move kallsyms support into " Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 10/14] module: kallsyms: Fix suspicious rcu usage Aaron Tomlin
2022-03-01 16:52 ` Aaron Tomlin
2022-03-02 17:02 ` Aaron Tomlin
2022-03-02 22:24 ` Luis Chamberlain
2022-02-28 23:43 ` [PATCH v9 11/14] module: Move procfs support into a separate file Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 12/14] module: Move sysfs " Aaron Tomlin
2022-02-28 23:43 ` [PATCH v9 13/14] module: Move kdb_modules list out of core code Aaron Tomlin
2022-03-02 16:19 ` Daniel Thompson [this message]
2022-03-02 16:26 ` Daniel Thompson
2022-03-02 20:31 ` Aaron Tomlin
2022-03-02 20:56 ` Christophe Leroy
2022-03-02 22:46 ` Luis Chamberlain
2022-03-03 10:44 ` Aaron Tomlin
2022-03-03 14:57 ` Luis Chamberlain
2022-03-03 13:37 ` Christoph Hellwig
2022-03-03 14:59 ` Daniel Thompson
2022-03-03 17:54 ` Christoph Hellwig
2022-03-03 18:16 ` Christophe Leroy
2022-03-03 19:00 ` Christoph Hellwig
2022-03-03 19:21 ` Luis Chamberlain
2022-03-04 11:12 ` Aaron Tomlin
2022-03-04 11:54 ` Daniel Thompson
2022-03-04 11:59 ` Aaron Tomlin
2022-03-03 12:55 ` Daniel Thompson
2022-02-28 23:43 ` [PATCH v9 14/14] module: Move version support into a separate file Aaron Tomlin
2022-03-01 0:21 ` [PATCH v9 00/14] module: core code clean up Luis Chamberlain
2022-03-01 7:07 ` Christophe Leroy
2022-03-01 16:00 ` Luis Chamberlain
2022-03-01 7:44 ` Christophe Leroy
2022-03-01 16:01 ` Luis Chamberlain
2022-03-01 17:15 ` Lucas De Marchi
2022-03-01 17:43 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302161917.gx5icfszakoye4uh@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=allen.lkml@gmail.com \
--cc=atomlin@atomlin.com \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=cl@linux.com \
--cc=jason.wessel@windriver.com \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=msuchanek@suse.de \
--cc=oleksandr@natalenko.name \
--cc=pmladek@suse.com \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).