From: "Cédric Le Goater" <clg@kaod.org>
To: linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: "Mark Brown" <broonie@kernel.org>,
"Tudor Ambarus" <tudor.ambarus@microchip.com>,
"Pratyush Yadav" <p.yadav@ti.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-aspeed@lists.ozlabs.org, "Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Chin-Ting Kuo" <chin-ting_kuo@aspeedtech.com>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Cédric Le Goater" <clg@kaod.org>,
"Tao Ren" <rentao.bupt@gmail.com>
Subject: [PATCH v3 07/11] spi: aspeed: Workaround AST2500 limitations
Date: Fri, 4 Mar 2022 09:36:39 +0100 [thread overview]
Message-ID: <20220304083643.1079142-8-clg@kaod.org> (raw)
In-Reply-To: <20220304083643.1079142-1-clg@kaod.org>
It is not possible to configure a full 128MB window for a chip of the
same size on the AST2500 SPI controller. For this case, the maximum
window size is restricted to 120MB for CE0.
Reviewed-by: Joel Stanley <joel@jms.id.au>
Tested-by: Joel Stanley <joel@jms.id.au>
Tested-by: Tao Ren <rentao.bupt@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
drivers/spi/spi-aspeed-smc.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
index 9f7910e79ae8..ab6fa5cfad9c 100644
--- a/drivers/spi/spi-aspeed-smc.c
+++ b/drivers/spi/spi-aspeed-smc.c
@@ -443,6 +443,8 @@ static int aspeed_spi_set_window(struct aspeed_spi *aspi,
* - ioremap each window, not strictly necessary since the overall window
* is correct.
*/
+static const struct aspeed_spi_data ast2500_spi_data;
+
static int aspeed_spi_chip_adjust_window(struct aspeed_spi_chip *chip,
u32 local_offset, u32 size)
{
@@ -451,6 +453,16 @@ static int aspeed_spi_chip_adjust_window(struct aspeed_spi_chip *chip,
struct aspeed_spi_window *win = &windows[chip->cs];
int ret;
+ /*
+ * Due to an HW issue on the AST2500 SPI controller, the CE0
+ * window size should be smaller than the maximum 128MB.
+ */
+ if (aspi->data == &ast2500_spi_data && chip->cs == 0 && size == SZ_128M) {
+ size = 120 << 20;
+ dev_info(aspi->dev, "CE%d window resized to %dMB (AST2500 HW quirk)",
+ chip->cs, size >> 20);
+ }
+
aspeed_spi_get_windows(aspi, windows);
/* Adjust this chip window */
--
2.34.1
next prev parent reply other threads:[~2022-03-04 8:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 8:36 [PATCH v3 00/11] spi: spi-mem: Add driver for Aspeed SMC controllers Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 01/11] mtd: spi-nor: aspeed: Rename Kconfig option Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 02/11] ARM: dts: aspeed: Adjust "reg" property of FMC/SPI controllers Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 03/11] dt-bindings: spi: Add Aspeed SMC controllers device tree binding Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 04/11] spi: spi-mem: Add driver for Aspeed SMC controllers Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 05/11] spi: aspeed: Add support for direct mapping Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 06/11] spi: aspeed: Adjust direct mapping to device size Cédric Le Goater
2022-03-04 8:36 ` Cédric Le Goater [this message]
2022-03-04 8:36 ` [PATCH v3 08/11] spi: aspeed: Add support for the AST2400 SPI controller Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 09/11] spi: aspeed: Calibrate read timings Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 10/11] ARM: dts: aspeed: Enable Dual SPI RX transfers Cédric Le Goater
2022-03-04 8:36 ` [PATCH v3 11/11] ARM: dts: aspeed-g4: Set spi-max-frequency for all flashes Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304083643.1079142-8-clg@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=broonie@kernel.org \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=rentao.bupt@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).