From: Shakeel Butt <shakeelb@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Eric Dumazet <edumazet@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>, Wei Xu <weixugc@google.com>,
Greg Thelen <gthelen@google.com>, Hugh Dickins <hughd@google.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2] mm/page_alloc: call check_new_pages() while zone spinlock is not held
Date: Fri, 4 Mar 2022 19:19:24 +0000 [thread overview]
Message-ID: <20220304191924.75zuylhmgvlb6zt4@google.com> (raw)
In-Reply-To: <20220304170215.1868106-1-eric.dumazet@gmail.com>
On Fri, Mar 04, 2022 at 09:02:15AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
> For high order pages not using pcp, rmqueue() is currently calling
> the costly check_new_pages() while zone spinlock is held,
> and hard irqs masked.
> This is not needed, we can release the spinlock sooner to reduce
> zone spinlock contention.
> Note that after this patch, we call __mod_zone_freepage_state()
> before deciding to leak the page because it is in bad state.
> v2: We need to keep interrupts disabled to call
> __mod_zone_freepage_state()
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Shakeel Butt <shakeelb@google.com>
> Cc: Wei Xu <weixugc@google.com>
> Cc: Greg Thelen <gthelen@google.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: David Rientjes <rientjes@google.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
next prev parent reply other threads:[~2022-03-04 19:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 17:02 [PATCH v2] mm/page_alloc: call check_new_pages() while zone spinlock is not held Eric Dumazet
2022-03-04 19:19 ` Shakeel Butt [this message]
2022-03-06 22:15 ` David Rientjes
2022-03-07 9:15 ` Mel Gorman
2022-03-08 23:49 ` Eric Dumazet
2022-03-09 12:32 ` Mel Gorman
2022-03-09 17:32 ` Eric Dumazet
2022-03-12 15:43 ` [mm/page_alloc] 8212a964ee: vm-scalability.throughput 30.5% improvement kernel test robot
2022-03-12 18:58 ` Vlastimil Babka
2022-03-12 23:26 ` Eric Dumazet
2022-03-13 9:28 ` Vlastimil Babka
2022-03-13 21:10 ` Eric Dumazet
2022-03-13 21:18 ` Matthew Wilcox
2022-03-13 21:27 ` Eric Dumazet
2022-03-13 21:36 ` Eric Dumazet
2022-03-14 9:09 ` Vlastimil Babka
2022-03-07 9:24 ` [PATCH v2] mm/page_alloc: call check_new_pages() while zone spinlock is not held Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304191924.75zuylhmgvlb6zt4@google.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gthelen@google.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).