linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Jack Wu <wjack@google.com>
Cc: kernel-team@android.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, AleX Pelosi <apelosi@google.com>,
	Vincent Wang <vincentwang@google.com>,
	Ken Yang <yangken@google.com>
Subject: Re: [PATCH v1] power: supply: add dock type
Date: Fri, 4 Mar 2022 23:00:49 +0100	[thread overview]
Message-ID: <20220304220049.y7klqsgqinonsojx@mercury.elektranox.org> (raw)
In-Reply-To: <CAHnoD8DPRvBXP04H3zzBsefvzvfzVuk271-+WAtYV_2KJBbFEw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3082 bytes --]

Hi,

When you send a new patch version you should

a) increase patch version (this is v2)
b) add a changelog below the --- marker

Apart from that this submission is still missing a
driver using the newly introduced POWER_SUPPLY_TYPE_DOCK.
Mainline kernel ABI is only extended for mainline kernel
users.

Thanks,

-- Sebastian

On Mon, Feb 14, 2022 at 02:22:52PM +0800, Jack Wu wrote:
> + Ken
> 
> Jack Wu <wjack@google.com> 於 2022年1月7日 週五 上午11:37寫道:
> >
> > + Alex and Vincent
> >
> > Jack Wu <wjack@google.com> 於 2022年1月4日 週二 下午8:25寫道:
> > >
> > > Add dock power_supply_type for the drivers which supports dock can
> > > register a power supply class device with POWER_SUPPLY_TYPE_DOCK.
> > >
> > > Signed-off-by: Jack Wu <wjack@google.com>
> > > ---
> > >  Documentation/ABI/testing/sysfs-class-power | 2 +-
> > >  drivers/power/supply/power_supply_sysfs.c   | 1 +
> > >  include/linux/power_supply.h                | 1 +
> > >  3 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > > index f7904efc4cfa..854299a0d36f 100644
> > > --- a/Documentation/ABI/testing/sysfs-class-power
> > > +++ b/Documentation/ABI/testing/sysfs-class-power
> > > @@ -34,7 +34,7 @@ Description:
> > >                 Describes the main type of the supply.
> > >
> > >                 Access: Read
> > > -               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless"
> > > +               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless", "Dock"
> > >
> > >  **Battery and USB properties**
> > >
> > > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> > > index c3d7cbcd4fad..53494b56bbb4 100644
> > > --- a/drivers/power/supply/power_supply_sysfs.c
> > > +++ b/drivers/power/supply/power_supply_sysfs.c
> > > @@ -57,6 +57,7 @@ static const char * const POWER_SUPPLY_TYPE_TEXT[] = {
> > >         [POWER_SUPPLY_TYPE_USB_PD_DRP]          = "USB_PD_DRP",
> > >         [POWER_SUPPLY_TYPE_APPLE_BRICK_ID]      = "BrickID",
> > >         [POWER_SUPPLY_TYPE_WIRELESS]            = "Wireless",
> > > +       [POWER_SUPPLY_TYPE_DOCK]                = "Dock",
> > >  };
> > >
> > >  static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {
> > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> > > index 9ca1f120a211..fa80eaa54242 100644
> > > --- a/include/linux/power_supply.h
> > > +++ b/include/linux/power_supply.h
> > > @@ -187,6 +187,7 @@ enum power_supply_type {
> > >         POWER_SUPPLY_TYPE_USB_PD_DRP,           /* PD Dual Role Port */
> > >         POWER_SUPPLY_TYPE_APPLE_BRICK_ID,       /* Apple Charging Method */
> > >         POWER_SUPPLY_TYPE_WIRELESS,             /* Wireless */
> > > +       POWER_SUPPLY_TYPE_DOCK,                 /* Dock Charging */
> > >  };
> > >
> > >  enum power_supply_usb_type {
> > > --
> > > 2.34.1.448.ga2b2bfdf31-goog
> > >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-03-04 22:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 12:24 Jack Wu
2022-01-07  3:37 ` Jack Wu
2022-02-14  6:22   ` Jack Wu
2022-03-04 22:00     ` Sebastian Reichel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-07  3:31 Jack Wu
2021-12-15  3:34 Jack Wu
2022-01-03 17:52 ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304220049.y7klqsgqinonsojx@mercury.elektranox.org \
    --to=sebastian.reichel@collabora.com \
    --cc=apelosi@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=vincentwang@google.com \
    --cc=wjack@google.com \
    --cc=yangken@google.com \
    --subject='Re: [PATCH v1] power: supply: add dock type' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).