linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chengming Zhou <zhouchengming@bytedance.com>
To: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
	peterz@infradead.org
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	songmuchun@bytedance.com,
	Chengming Zhou <zhouchengming@bytedance.com>,
	Linux Kernel Functional Testing <lkft@linaro.org>,
	syzbot+16e3f2c77e7c5a0113f9@syzkaller.appspotmail.com,
	Zhouyi Zhou <zhouzhouyi@gmail.com>
Subject: [PATCH linux-next] cgroup: fix suspicious rcu_dereference_check() usage warning
Date: Sat,  5 Mar 2022 11:41:03 +0800	[thread overview]
Message-ID: <20220305034103.57123-1-zhouchengming@bytedance.com> (raw)

task_css_set_check() will use rcu_dereference_check() to check for
rcu_read_lock_held() on the read-side, which is not true after commit
dc6e0818bc9a ("sched/cpuacct: Optimize away RCU read lock"). This
commit drop explicit rcu_read_lock(), change to RCU-sched read-side
critical section. So fix the RCU warning by adding check for
rcu_read_lock_sched_held().

Fixes: dc6e0818bc9a ("sched/cpuacct: Optimize away RCU read lock")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Reported-by: syzbot+16e3f2c77e7c5a0113f9@syzkaller.appspotmail.com
Tested-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 include/linux/cgroup.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 1e356c222756..0d1ada8968d7 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -450,6 +450,7 @@ extern struct mutex cgroup_mutex;
 extern spinlock_t css_set_lock;
 #define task_css_set_check(task, __c)					\
 	rcu_dereference_check((task)->cgroups,				\
+		rcu_read_lock_sched_held() ||				\
 		lockdep_is_held(&cgroup_mutex) ||			\
 		lockdep_is_held(&css_set_lock) ||			\
 		((task)->flags & PF_EXITING) || (__c))
-- 
2.20.1


             reply	other threads:[~2022-03-05  3:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-05  3:41 Chengming Zhou [this message]
     [not found] ` <CGME20220309071027eucas1p1f066b42f49e524404d898929b60b344f@eucas1p1.samsung.com>
2022-03-09  7:10   ` [PATCH linux-next] cgroup: fix suspicious rcu_dereference_check() usage warning Marek Szyprowski
2022-03-09 18:10 ` Tejun Heo
2022-03-12 12:19 ` Peter Zijlstra
2022-03-12 13:34   ` Peter Zijlstra
2022-03-12 15:54     ` [External] " Chengming Zhou
2022-03-12 12:37 ` [tip: sched/core] cgroup: Fix " tip-bot2 for Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220305034103.57123-1-zhouchengming@bytedance.com \
    --to=zhouchengming@bytedance.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=lkft@linaro.org \
    --cc=peterz@infradead.org \
    --cc=songmuchun@bytedance.com \
    --cc=syzbot+16e3f2c77e7c5a0113f9@syzkaller.appspotmail.com \
    --cc=tj@kernel.org \
    --cc=zhouzhouyi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).