From: Christoph Hellwig <hch@lst.de>
To: Mingbao Sun <sunmingbao@tom.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com,
libin.zhang@dell.com, ao.sun@dell.com
Subject: Re: [PATCH 2/2] nvme-tcp: support specifying the congestion-control
Date: Tue, 8 Mar 2022 08:12:27 +0100 [thread overview]
Message-ID: <20220308071227.GB24575@lst.de> (raw)
In-Reply-To: <20220305150915.00006b44@tom.com>
On Sat, Mar 05, 2022 at 03:09:15PM +0800, Mingbao Sun wrote:
> Well, actually I did have thought whether the calling of network API
> here is proper. Since I did find that there is no call to APIs of
> PCI/RDMA/TCP in fabrics.c.
Yes - for a good reason. Without networking support your patch won't
even compile (both the host and target side).
> But I hope the following could make a defense for it:
>
> Anyway, we need to validate the tcp_congestion passed in from
> user-space, right?
Do we? It seems like no one else really calls this routine to verify
things. In fact it has no modular users at all in the current tree.
> The role of nvmf_parse_options is similar to that of
> drivers/nvme/target/configfs.c from the target side.
> And both of them can not avoid handling specific options of the
> sub-classes (e.g., NVMF_OPT_HDR_DIGEST, NVMF_OPT_TOS, NVMF_OPT_KATO).
NVMF_OPT_KATO is completely generic, but yes, there other two are
transport specific. None of them calls out into other modules
that would need dependecies, though.
I'm also a little concerned that no other in kernel user like iSCSI,
NBD or NFS has any code like this.
next prev parent reply other threads:[~2022-03-08 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 9:27 [PATCH 0/2] NVMe_over_TCP: support specifying the congestion-control Mingbao Sun
2022-03-04 9:27 ` [PATCH 1/2] nvmet-tcp: " Mingbao Sun
2022-03-04 9:27 ` [PATCH 2/2] nvme-tcp: " Mingbao Sun
2022-03-04 16:20 ` Christoph Hellwig
2022-03-05 7:09 ` Mingbao Sun
2022-03-08 7:12 ` Christoph Hellwig [this message]
2022-03-08 7:57 ` Mingbao Sun
2022-03-08 13:03 ` [PATCH 0/2] NVMe_over_TCP: " Mingbao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308071227.GB24575@lst.de \
--to=hch@lst.de \
--cc=ao.sun@dell.com \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=libin.zhang@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ping.gan@dell.com \
--cc=sagi@grimberg.me \
--cc=sunmingbao@tom.com \
--cc=tyler.sun@dell.com \
--cc=yanxiu.cai@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).