From: Tianchen Ding <dtcccc@linux.alibaba.com>
To: Zefan Li <lizefan.x@bytedance.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Tianchen Ding <dtcccc@linux.alibaba.com>,
Michael Wang <yun.wang@linux.alibaba.com>,
Cruz Zhao <cruzzhao@linux.alibaba.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Miguel Ojeda <ojeda@kernel.org>,
Chris Down <chris@chrisdown.name>,
Vipin Sharma <vipinsh@google.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: [RFC PATCH v2 4/4] cpuset, gb: Add stat for group balancer
Date: Tue, 8 Mar 2022 17:26:29 +0800 [thread overview]
Message-ID: <20220308092629.40431-5-dtcccc@linux.alibaba.com> (raw)
In-Reply-To: <20220308092629.40431-1-dtcccc@linux.alibaba.com>
When group balancer is enabled by:
echo 200000 > $CGROUP_PATH/cpuset.gb.period_us
Then you can check:
$CPU_CGROUP_PATH/childX/cpuset.gb.stat
which give output as:
PART-0 0-15 1008 1086 *
PART-1 16-31 0 2
PART-2 32-47 0 0
PART-3 48-63 0 1024
The partition ID followed by it's CPUs range, load of group, load
of partition and a star mark as preferred.
Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
---
include/linux/sched/gb.h | 2 ++
kernel/cgroup/cpuset.c | 24 ++++++++++++++++++++++++
kernel/sched/gb.c | 25 +++++++++++++++++++++++++
3 files changed, 51 insertions(+)
diff --git a/include/linux/sched/gb.h b/include/linux/sched/gb.h
index 7af91662b740..ec5a97d8160a 100644
--- a/include/linux/sched/gb.h
+++ b/include/linux/sched/gb.h
@@ -63,6 +63,8 @@ static inline struct cpumask *part_cpus(struct gb_part_info *pi, int id)
#ifdef CONFIG_GROUP_BALANCER
extern unsigned int sysctl_gb_settle_period;
+int gb_stat_show(struct seq_file *sf, struct cgroup_subsys_state *css,
+ struct gb_info *gi, struct gb_part_info *pi);
#endif
#endif
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index de13c22c1921..035606e8fa95 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -2863,6 +2863,24 @@ static ssize_t gb_partition_write(struct kernfs_open_file *of, char *buf,
cpus_read_unlock();
return retval ?: nbytes;
}
+
+static int gb_stat_seq_show(struct seq_file *sf, void *v)
+{
+ struct cgroup_subsys_state *css = seq_css(sf);
+ struct gb_info *control_gi;
+ int retval = -EINVAL;
+
+ rcu_read_lock();
+ control_gi = css_gi(css, true);
+ if (!control_gi || !control_gi->gb_period)
+ goto out_unlock;
+
+ retval = gb_stat_show(sf, css, css_gi(css, false), control_gi->part_info);
+
+out_unlock:
+ rcu_read_unlock();
+ return retval;
+}
#else
static inline void init_gb(struct cpuset *cs) { }
static inline void remove_gb(struct cpuset *cs) { }
@@ -3179,6 +3197,12 @@ static struct cftype dfl_files[] = {
.max_write_len = (100U + 6 * NR_CPUS),
.private = FILE_GB_CPULIST,
},
+
+ {
+ .name = "gb.stat",
+ .seq_show = gb_stat_seq_show,
+ .flags = CFTYPE_NOT_ON_ROOT,
+ },
#endif
{ } /* terminate */
};
diff --git a/kernel/sched/gb.c b/kernel/sched/gb.c
index f7da96253ad0..8ae1db83b587 100644
--- a/kernel/sched/gb.c
+++ b/kernel/sched/gb.c
@@ -46,6 +46,31 @@ static u64 load_of_part(struct gb_part_info *pi, int id)
return load;
}
+int gb_stat_show(struct seq_file *sf, struct cgroup_subsys_state *css,
+ struct gb_info *gi, struct gb_part_info *pi)
+{
+ struct cgroup_subsys_state *tg_css;
+ struct task_group *tg;
+ int i;
+
+ tg_css = cgroup_e_css(css->cgroup, &cpu_cgrp_subsys);
+ /* Make sure that "cpu" and "cpuset" subsys belonging to the same cgroup. */
+ if (tg_css->cgroup != css->cgroup)
+ return -EINVAL;
+ tg = container_of(tg_css, struct task_group, css);
+
+ for_each_gbpart(i, pi) {
+ seq_printf(sf, "PART-%d ", i);
+ seq_printf(sf, "%*pbl ", cpumask_pr_args(part_cpus(pi, i)));
+ seq_printf(sf, "%llu ", tg_load_of_part(pi, tg, i));
+ seq_printf(sf, "%llu ", load_of_part(pi, i));
+ if (gi->gb_prefer == i)
+ seq_puts(sf, " *");
+ seq_putc(sf, '\n');
+ }
+ return 0;
+}
+
static inline int part_mgrt_lock(struct gb_part_info *pi, int src, int dst)
{
struct gb_part *src_part, *dst_part;
--
2.27.0
next prev parent reply other threads:[~2022-03-08 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 9:26 [RFC PATCH v2 0/4] Introduce group balancer Tianchen Ding
2022-03-08 9:26 ` [RFC PATCH v2 1/4] sched, cpuset: Introduce infrastructure of " Tianchen Ding
2022-03-08 9:26 ` [RFC PATCH v2 2/4] cpuset: Handle input of partition info for " Tianchen Ding
2022-03-08 9:26 ` [RFC PATCH v2 3/4] sched: Introduce " Tianchen Ding
2022-03-08 9:26 ` Tianchen Ding [this message]
2022-03-08 17:13 ` [RFC PATCH v2 0/4] " Tejun Heo
2022-03-09 8:30 ` Tianchen Ding
2022-03-09 18:00 ` Tejun Heo
2022-03-10 5:47 ` Tianchen Ding
2022-03-21 18:16 ` Tejun Heo
2022-03-24 6:50 ` Tianchen Ding
2022-04-06 2:47 ` Tianchen Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220308092629.40431-5-dtcccc@linux.alibaba.com \
--to=dtcccc@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=cruzzhao@linux.alibaba.com \
--cc=daniel@iogearbox.net \
--cc=dietmar.eggemann@arm.com \
--cc=gustavoars@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=masahiroy@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=vipinsh@google.com \
--cc=yun.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).