From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 18/29] rtc: spear: switch to devm_rtc_allocate_device
Date: Wed, 9 Mar 2022 17:22:49 +0100 [thread overview]
Message-ID: <20220309162301.61679-18-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20220309162301.61679-1-alexandre.belloni@bootlin.com>
Switch to devm_rtc_allocate_device/devm_rtc_register_device, this allows
for further improvement of the driver.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-spear.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
index b4a520056b1a..1b40380aaba2 100644
--- a/drivers/rtc/rtc-spear.c
+++ b/drivers/rtc/rtc-spear.c
@@ -352,6 +352,10 @@ static int spear_rtc_probe(struct platform_device *pdev)
if (!config)
return -ENOMEM;
+ config->rtc = devm_rtc_allocate_device(&pdev->dev);
+ if (IS_ERR(config->rtc))
+ return PTR_ERR(config->rtc);
+
/* alarm irqs */
irq = platform_get_irq(pdev, 0);
if (irq < 0)
@@ -380,17 +384,13 @@ static int spear_rtc_probe(struct platform_device *pdev)
spin_lock_init(&config->lock);
platform_set_drvdata(pdev, config);
- config->rtc = devm_rtc_device_register(&pdev->dev, pdev->name,
- &spear_rtc_ops, THIS_MODULE);
- if (IS_ERR(config->rtc)) {
- dev_err(&pdev->dev, "can't register RTC device, err %ld\n",
- PTR_ERR(config->rtc));
- status = PTR_ERR(config->rtc);
- goto err_disable_clock;
- }
-
+ config->rtc->ops = &spear_rtc_ops;
config->rtc->uie_unsupported = 1;
+ status = devm_rtc_register_device(config->rtc);
+ if (status)
+ goto err_disable_clock;
+
if (!device_can_wakeup(&pdev->dev))
device_init_wakeup(&pdev->dev, 1);
--
2.35.1
next prev parent reply other threads:[~2022-03-09 16:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 16:22 [PATCH 01/29] rtc: ds1685: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 02/29] rtc: ds1685: drop no_irq Alexandre Belloni
2022-03-09 16:22 ` [PATCH 03/29] rtc: ds1307: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 04/29] rtc: mpc5121: let the core handle the alarm resolution Alexandre Belloni
2022-03-09 16:22 ` [PATCH 05/29] rtc: mpc5121: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 06/29] rtc: m41t80: " Alexandre Belloni
2022-03-09 16:22 ` [PATCH 07/29] rtc: opal: " Alexandre Belloni
2022-03-09 16:22 ` [PATCH 08/29] rtc: pcf2123: " Alexandre Belloni
2022-03-09 16:22 ` [PATCH 09/29] rtc: pcf2123: set RTC_FEATURE_ALARM_RES_MINUTE Alexandre Belloni
2022-03-09 16:22 ` [PATCH 10/29] rtc: pcf2127: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 11/29] rtc: pcf2127: set RTC_FEATURE_ALARM_RES_2S Alexandre Belloni
2022-03-10 16:09 ` Hugo Villeneuve
2022-03-10 20:58 ` Alexandre Belloni
2022-03-10 21:12 ` Hugo Villeneuve
2022-03-17 15:28 ` Hugo Villeneuve
2022-03-17 17:16 ` Alexandre Belloni
2022-05-24 15:10 ` Hugo Villeneuve
2022-12-15 15:12 ` Hugo Villeneuve
2022-03-09 16:22 ` [PATCH 12/29] rtc: pcf85063: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 13/29] rtc: pcf85063: set RTC_FEATURE_ALARM_RES_2S Alexandre Belloni
2022-03-09 16:22 ` [PATCH 14/29] rtc: pcf8523: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 15/29] rtc: pcf8523: let the core handle the alarm resolution Alexandre Belloni
2022-03-09 16:22 ` [PATCH 16/29] rtc: pcf8563: " Alexandre Belloni
2022-03-09 16:22 ` [PATCH 17/29] rtc: pcf8563: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` Alexandre Belloni [this message]
2022-03-10 3:29 ` [PATCH 18/29] rtc: spear: switch to devm_rtc_allocate_device Viresh Kumar
2022-03-09 16:22 ` [PATCH 19/29] rtc: spear: set range Alexandre Belloni
2022-03-10 3:28 ` Viresh Kumar
2022-03-09 16:22 ` [PATCH 20/29] rtc: spear: drop uie_unsupported Alexandre Belloni
2022-03-10 3:29 ` Viresh Kumar
2022-03-09 16:22 ` [PATCH 21/29] rtc: spear: fix spear_rtc_read_time Alexandre Belloni
2022-03-10 3:28 ` Viresh Kumar
2022-03-09 16:22 ` [PATCH 22/29] rtc: add new RTC_FEATURE_ALARM_WAKEUP_ONLY feature Alexandre Belloni
2022-03-09 16:22 ` [PATCH 23/29] rtc: efi: switch to devm_rtc_allocate_device Alexandre Belloni
2022-03-09 16:22 ` [PATCH 24/29] rtc: efi: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 25/29] rtc: hym8563: switch to devm_rtc_allocate_device Alexandre Belloni
2022-03-09 16:22 ` [PATCH 26/29] rtc: hym8563: let the core handle the alarm resolution Alexandre Belloni
2022-03-09 16:22 ` [PATCH 27/29] rtc: hym8563: switch to RTC_FEATURE_UPDATE_INTERRUPT Alexandre Belloni
2022-03-09 16:22 ` [PATCH 28/29] rtc: xgene: stop using uie_unsupported Alexandre Belloni
2022-03-09 16:23 ` [PATCH 29/29] rtc: remove uie_unsupported Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309162301.61679-18-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).