From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C047C433F5 for ; Wed, 9 Mar 2022 18:22:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236054AbiCISX0 (ORCPT ); Wed, 9 Mar 2022 13:23:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235989AbiCISXW (ORCPT ); Wed, 9 Mar 2022 13:23:22 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 305DC574BF; Wed, 9 Mar 2022 10:22:23 -0800 (PST) Received: from fraeml702-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4KDLBS6h5Vz67SnY; Thu, 10 Mar 2022 02:21:52 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml702-chm.china.huawei.com (10.206.15.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Wed, 9 Mar 2022 19:22:21 +0100 Received: from localhost (10.47.72.217) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 9 Mar 2022 18:22:20 +0000 Date: Wed, 9 Mar 2022 18:22:17 +0000 From: Jonathan Cameron To: Dan Williams CC: , , "Alison Schofield" , Vishal Verma , Ira Weiny , Ben Widawsky , , , Subject: Re: [PATCH 03/11] cxl/core: Remove cxl_device_lock() Message-ID: <20220309182217.00006bf5@Huawei.com> In-Reply-To: <164610294604.2682974.11169622387063183603.stgit@dwillia2-desk3.amr.corp.intel.com> References: <164610292916.2682974.12924748003366352335.stgit@dwillia2-desk3.amr.corp.intel.com> <164610294604.2682974.11169622387063183603.stgit@dwillia2-desk3.amr.corp.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.72.217] X-ClientProxiedBy: lhreml733-chm.china.huawei.com (10.201.108.84) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Feb 2022 18:49:06 -0800 Dan Williams wrote: > In preparation for moving lockdep_mutex nested lock acquisition into the > core, remove the cxl_device_lock() wrapper, but preserve > cxl_lock_class() that will be used to inform the core of the subsystem's > lock ordering rules. > > Cc: Alison Schofield > Cc: Vishal Verma > Cc: Ira Weiny > Cc: Ben Widawsky > Signed-off-by: Dan Williams Makes sense, but perhaps the description should call out that after this patch it's not just a wrapper remove, but rather the lock checking is totally gone for now? Otherwise this looks fine to me. FWIW Reviewed-by: Jonathan Cameron