From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
arnaud.pouliquen@foss.st.com
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
peng.fan@nxp.com
Subject: [PATCH V3 1/2] remoteproc: introduce rproc features
Date: Thu, 10 Mar 2022 07:01:27 +0800 [thread overview]
Message-ID: <20220309230128.15856-2-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20220309230128.15856-1-peng.fan@oss.nxp.com>
From: Peng Fan <peng.fan@nxp.com>
remote processor may support:
- firmware recovery with help from main processor
- self recovery without help from main processor
- iommu
- etc
Introduce rproc features could simplify code to avoid adding more bool
flags and let us optimize current code.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
Resend
V2-version 2:
New
include/linux/remoteproc.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index 93a1d0050fbc..51edaf80692c 100644
--- a/include/linux/remoteproc.h
+++ b/include/linux/remoteproc.h
@@ -417,6 +417,7 @@ struct rproc_ops {
* has attached to it
* @RPROC_DETACHED: device has been booted by another entity and waiting
* for the core to attach to it
+ * @RPROC_CRASHED_ATTACH_RECOVERY: device has crashed and self recovery
* @RPROC_LAST: just keep this one at the end
*
* Please note that the values of these states are used as indices
@@ -489,6 +490,11 @@ struct rproc_dump_segment {
loff_t offset;
};
+enum rproc_features {
+ RPROC_FEAT_ATTACH_RECOVERY = 0,
+ RPROC_MAX_FEATURES = 32,
+};
+
/**
* struct rproc - represents a physical remote processor device
* @node: list node of this rproc object
@@ -530,6 +536,7 @@ struct rproc_dump_segment {
* @elf_machine: firmware ELF machine
* @cdev: character device of the rproc
* @cdev_put_on_release: flag to indicate if remoteproc should be shutdown on @char_dev release
+ * @features: indicate remoteproc features
*/
struct rproc {
struct list_head node;
@@ -570,8 +577,19 @@ struct rproc {
u16 elf_machine;
struct cdev cdev;
bool cdev_put_on_release;
+ DECLARE_BITMAP(features, RPROC_MAX_FEATURES);
};
+static inline bool rproc_has_feature(struct rproc *rproc, unsigned int feature)
+{
+ return test_bit(feature, rproc->features);
+}
+
+static inline void rproc_set_feature(struct rproc *rproc, unsigned int feature)
+{
+ set_bit(feature, rproc->features);
+}
+
/**
* struct rproc_subdev - subdevice tied to a remoteproc
* @node: list node related to the rproc subdevs list
--
2.30.0
next prev parent reply other threads:[~2022-03-09 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 23:01 [PATCH V3 0/2] remoteproc: support self recovery Peng Fan (OSS)
2022-03-09 23:01 ` Peng Fan (OSS) [this message]
2022-03-09 23:01 ` [PATCH V3 2/2] remoteproc: support attach recovery after rproc crash Peng Fan (OSS)
2022-03-11 21:20 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309230128.15856-2-peng.fan@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).