From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B3DC433F5 for ; Thu, 10 Mar 2022 12:59:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242218AbiCJNA0 (ORCPT ); Thu, 10 Mar 2022 08:00:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231868AbiCJNAY (ORCPT ); Thu, 10 Mar 2022 08:00:24 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1343E5748D for ; Thu, 10 Mar 2022 04:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646917162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hwCuIDSsPjX4AERceBeOtiMJvDAZVLHVVFLuVfFYlm4=; b=BH7O8ZkaqBXBI7e5a3Sg3UozcHA2L49+QDlxMCk/J9NROom0uIwsARykkzgXjmPEmIt11F x4ptZDV896fqck7OOBNx5OC9KIIJpthVmdqbYwMdT0G8mTNs7uihjFnPl+iabfYzPjVYID +56C70l3Qu11nbD9suc/eO/nBxSS8MI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-657-EQymJ4ChMcqemAhyTEkEjw-1; Thu, 10 Mar 2022 07:59:21 -0500 X-MC-Unique: EQymJ4ChMcqemAhyTEkEjw-1 Received: by mail-wm1-f69.google.com with SMTP id a26-20020a7bc1da000000b003857205ec7cso2270308wmj.2 for ; Thu, 10 Mar 2022 04:59:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hwCuIDSsPjX4AERceBeOtiMJvDAZVLHVVFLuVfFYlm4=; b=5JGetI7//s7QL6CWJ1ES+VSuXV/veusgHuIowQ4+rU9awfh1vNsIsy0bAbkSNIgbPU OtDROGvPU4we6pYnzJHqLglfp4Gi6i2d9FBDP6OusvjFUn5AAiyqny3mlLIu8bpNJQz7 UqHi823c3SKeUxPC7HDAjGY1Ez3hCxHORDPpo6XFUNg1yXq9ARCiOMH56+oKqOmzspYn eQqJ4bhVGTWur4mWtGpGBeztCxAeDkSkslPhKL2hMXidnxh8rfoZDZGtb2qAKZrCg13b hUaJzDWASvpHXAg3fwS4fvWG4EoasHEM2qDI23Uxw/J9bW/vAm0f7+1mxoP/QVuoYPSq Sg5g== X-Gm-Message-State: AOAM531A2fnOlDecoDfTRaOeQZp2EqpbxeIaf/rU0DwhVhB0mRLSaZE1 R74u84gLRYBW4dMPuCItPk7G29paatGPmhfgu3caIYnVfjZtuIHisMI2ijpUw5C+GxcAcjvkJJ8 Vs3Add+dT7DC6PuT4RZ/YfwnL X-Received: by 2002:adf:e74a:0:b0:1f0:25cb:3ad5 with SMTP id c10-20020adfe74a000000b001f025cb3ad5mr3347342wrn.231.1646917159910; Thu, 10 Mar 2022 04:59:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4qf2SKWvXQvwoAB9Gh/FK48f8OJZe69JH0iUoqd3J7EpB6Fi2Yt+tJIwgM/gUJZtaibSlQA== X-Received: by 2002:adf:e74a:0:b0:1f0:25cb:3ad5 with SMTP id c10-20020adfe74a000000b001f025cb3ad5mr3347324wrn.231.1646917159674; Thu, 10 Mar 2022 04:59:19 -0800 (PST) Received: from redhat.com ([2.53.27.107]) by smtp.gmail.com with ESMTPSA id n7-20020a05600c3b8700b00389a6241669sm8676255wms.33.2022.03.10.04.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 04:59:19 -0800 (PST) Date: Thu, 10 Mar 2022 07:59:15 -0500 From: "Michael S. Tsirkin" To: Jiyong Park Cc: sgarzare@redhat.com, stefanha@redhat.com, jasowang@redhat.com, davem@davemloft.net, kuba@kernel.org, adelva@google.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] vsock: cycle only on its own socket Message-ID: <20220310075854-mutt-send-email-mst@kernel.org> References: <20220310125425.4193879-1-jiyong@google.com> <20220310075554-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220310075554-mutt-send-email-mst@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 10, 2022 at 07:57:58AM -0500, Michael S. Tsirkin wrote: > On Thu, Mar 10, 2022 at 09:54:23PM +0900, Jiyong Park wrote: > > Hi Stefano, > > > > As suggested [1], I've made two patches for easier backporting without > > breaking KMI. > > > > PATCH 1 fixes the very issue of cycling all vsocks regardless of the > > transport and shall be backported. > > > > PATCH 2 is a refactor of PATCH 1 that forces the filtering to all > > (including future) uses of vsock_for_each_connected_socket. > > > > Thanks, > > > > [1] https://lore.kernel.org/lkml/20220310110036.fgy323c4hvk3mziq@sgarzare-redhat/ > > > OK that's better. Pls do include changelog in the future. > > Acked-by: Michael S. Tsirkin Hmm actually I think I have a better idea. Hang on. > > > > Jiyong Park (2): > > vsock: each transport cycles only on its own sockets > > vsock: refactor vsock_for_each_connected_socket > > > > drivers/vhost/vsock.c | 3 ++- > > include/net/af_vsock.h | 3 ++- > > net/vmw_vsock/af_vsock.c | 9 +++++++-- > > net/vmw_vsock/virtio_transport.c | 7 +++++-- > > net/vmw_vsock/vmci_transport.c | 3 ++- > > 5 files changed, 18 insertions(+), 7 deletions(-) > > > > > > base-commit: 3bf7edc84a9eb4007dd9a0cb8878a7e1d5ec6a3b > > -- > > 2.35.1.723.g4982287a31-goog