From: Jakub Kicinski <kuba@kernel.org>
To: menglong8.dong@gmail.com
Cc: dsahern@kernel.org, nhorman@tuxdriver.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, davem@davemloft.net, imagedong@tencent.com,
edumazet@google.com, talalahmad@google.com,
keescook@chromium.org, alobakin@pm.me,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, Mengen Sun <mengensun@tencent.com>,
Hao Peng <flyingpeng@tencent.com>
Subject: Re: [PATCH] net: skb: move enum skb_drop_reason to uapi
Date: Thu, 10 Mar 2022 19:54:29 -0800 [thread overview]
Message-ID: <20220310195429.4ba93edf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220311032828.702392-1-imagedong@tencent.com>
On Fri, 11 Mar 2022 11:28:28 +0800 menglong8.dong@gmail.com wrote:
> From: Menglong Dong <imagedong@tencent.com>
>
> Move the definition of 'enum skb_drop_reason' in 'skbuff.h' to the uapi
> header 'net_dropmon.h', therefore some users, such as eBPF program, can
> make use of it.
BPF does not need an enum definition to be part of the uAPI to make use
of it. BTF should encode the values, and CO-RE can protect from them
changing, AFAIU. I think we need a better example user / justification.
next prev parent reply other threads:[~2022-03-11 3:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 3:28 [PATCH] net: skb: move enum skb_drop_reason to uapi menglong8.dong
2022-03-11 3:54 ` Jakub Kicinski [this message]
2022-03-11 4:58 ` Menglong Dong
2022-03-11 22:23 ` Alexei Starovoitov
2022-03-11 20:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310195429.4ba93edf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alobakin@pm.me \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=imagedong@tencent.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mengensun@tencent.com \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=songliubraving@fb.com \
--cc=talalahmad@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).