From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93CCC433EF for ; Fri, 11 Mar 2022 16:14:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350202AbiCKQPw (ORCPT ); Fri, 11 Mar 2022 11:15:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350203AbiCKQPk (ORCPT ); Fri, 11 Mar 2022 11:15:40 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51B211D0875 for ; Fri, 11 Mar 2022 08:14:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE2A1B82A0A for ; Fri, 11 Mar 2022 16:14:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 990ADC340E9; Fri, 11 Mar 2022 16:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647015264; bh=+9YJo47L4Z/7RMv2dXuMlzuWDq6L4jN6JE7oXa3+yjM=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=K8X7vfNyIktB+eqHt7NIANY9dP1oAjIVJKbtLDcS3gtsezXufPzv8UYMRELsGzXhr yR+ijMmiwP5dyAT5yMwnXUrhsFYUYKMH6dpgsyjCvfHWaEKL58rTe+RMNDYHbfoX4+ Ws5siXrPbXSL29NKE/r72Rgk/rOTxbBID889Ck4MY3m/d2LPyHKdcgu9M55mLW7p/F Jicb81tb1CGloxerTwiex63GLTR2saZ/R3vK/Y8d0Z28utc0pHdcmLN3j560LOc4zR n0WU5xnTkOWcnZkZv4aGJ8HhKacCvtoUgJoNQBfsPLORkspZ1/pOXjfPKBVyqkFcN3 Npu6zb8EthIcg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 4AC275C0140; Fri, 11 Mar 2022 08:14:24 -0800 (PST) Date: Fri, 11 Mar 2022 08:14:24 -0800 From: "Paul E. McKenney" To: Frederic Weisbecker Cc: LKML , Peter Zijlstra , Phil Auld , Alex Belits , Nicolas Saenz Julienne , Xiongfeng Wang , Neeraj Upadhyay , Thomas Gleixner , Yu Liao , Boqun Feng , Marcelo Tosatti , Paul Gortmaker , Uladzislau Rezki , Joel Fernandes Subject: Re: [PATCH 14/19] rcu/context-tracking: Move RCU-dynticks internal functions to context_tracking Message-ID: <20220311161424.GH4285@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220302154810.42308-1-frederic@kernel.org> <20220302154810.42308-15-frederic@kernel.org> <20220310200705.GA4285@paulmck-ThinkPad-P17-Gen-1> <20220311160239.GE227945@lothringen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220311160239.GE227945@lothringen> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2022 at 05:02:39PM +0100, Frederic Weisbecker wrote: > On Thu, Mar 10, 2022 at 12:07:05PM -0800, Paul E. McKenney wrote: > > On Wed, Mar 02, 2022 at 04:48:05PM +0100, Frederic Weisbecker wrote: > > > Move the core RCU eqs/dynticks functions to context tracking so that > > > we can later merge all that code within context tracking. > > > > > > Signed-off-by: Frederic Weisbecker > > > > I am not sure that you want rcu_dynticks_task_enter() and friends in > > context tracking, but I have no objection to them living there. ;-) > > I initially tried to keep them in RCU headers but their use of "current" > would imply a circular dependency with sched.h. > > Not much appealing alternatives could be: > > * macrofying them > * uninline them and keep in RCU > > ... Sounds like good reasons for them to live outside of kernel/rcu. Thanx, Paul