From: Jakub Kicinski <kuba@kernel.org>
To: Kurt Cancemi <kurt@x64architecture.com>
Cc: netdev@vger.kernel.org, kabel@kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Charles-Antoine Couret <charles-antoine.couret@nexvision.fr>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: phy: marvell: Fix invalid comparison in the resume and suspend functions
Date: Mon, 14 Mar 2022 15:07:41 -0700 [thread overview]
Message-ID: <20220314150741.5e674da7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220312201512.326047-1-kurt@x64architecture.com>
On Sat, 12 Mar 2022 15:15:13 -0500 Kurt Cancemi wrote:
> - if (!linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
> + if (linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
> phydev->supported)) {
You should align the continuation lines so that the start matches
the opening parenthesis. I'll fix it up when applying for you this
time but please make sure to run checkpatch.pl --strict on patches
before submission. Thanks!
next prev parent reply other threads:[~2022-03-14 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220312002016.60416-1-kurt@x64architecture.com>
2022-03-12 20:15 ` [PATCH net v3] net: phy: marvell: Fix invalid comparison in the resume and suspend functions Kurt Cancemi
2022-03-12 20:25 ` Andrew Lunn
2022-03-14 22:07 ` Jakub Kicinski [this message]
2022-03-14 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314150741.5e674da7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=charles-antoine.couret@nexvision.fr \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=kurt@x64architecture.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).