From: Stefano Garzarella <sgarzare@redhat.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: stefanha@redhat.com, mst@redhat.com, jasowang@redhat.com,
arei.gonglei@huawei.com, yechuan@huawei.com,
huangzhichao@huawei.com,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/3] vdpa: support exposing the config size to userspace
Date: Tue, 15 Mar 2022 10:38:01 +0100 [thread overview]
Message-ID: <20220315093801.ngyizwf7blkhutug@sgarzare-redhat> (raw)
In-Reply-To: <20220315032553.455-2-longpeng2@huawei.com>
On Tue, Mar 15, 2022 at 11:25:51AM +0800, Longpeng(Mike) wrote:
>From: Longpeng <longpeng2@huawei.com>
>
>- GET_CONFIG_SIZE: return the size of the virtio config space.
>
>The size contains the fields which are conditional on feature
>bits.
>
>Acked-by: Jason Wang <jasowang@redhat.com>
>Signed-off-by: Longpeng <longpeng2@huawei.com>
>---
> drivers/vhost/vdpa.c | 17 +++++++++++++++++
> include/linux/vdpa.h | 3 ++-
> include/uapi/linux/vhost.h | 4 ++++
> 3 files changed, 23 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>index ec5249e..605c7ae 100644
>--- a/drivers/vhost/vdpa.c
>+++ b/drivers/vhost/vdpa.c
>@@ -355,6 +355,20 @@ static long vhost_vdpa_get_iova_range(struct vhost_vdpa *v, u32 __user *argp)
> return 0;
> }
>
>+static long vhost_vdpa_get_config_size(struct vhost_vdpa *v, u32 __user *argp)
>+{
>+ struct vdpa_device *vdpa = v->vdpa;
>+ const struct vdpa_config_ops *ops = vdpa->config;
>+ u32 size;
>+
>+ size = ops->get_config_size(vdpa);
get_config_size() returns a size_t, perhaps we could have a comment here
where we say we don't expect there to be an overflow.
I don't have a strong opinion on this, and I wouldn't want to get you to
repin just for that, so:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
next prev parent reply other threads:[~2022-03-15 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 3:25 [PATCH v2 0/3] vdpa: add two ioctl commands to support generic vDPA Longpeng(Mike)
2022-03-15 3:25 ` [PATCH v2 1/3] vdpa: support exposing the config size to userspace Longpeng(Mike)
2022-03-15 9:38 ` Stefano Garzarella [this message]
2022-03-15 3:25 ` [PATCH v2 2/3] vdpa: change the type of nvqs to u32 Longpeng(Mike)
2022-03-15 9:42 ` Stefano Garzarella
2022-03-15 3:25 ` [PATCH v2 3/3] vdpa: support exposing the count of vqs to userspace Longpeng(Mike)
2022-03-15 9:52 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315093801.ngyizwf7blkhutug@sgarzare-redhat \
--to=sgarzare@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=huangzhichao@huawei.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yechuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).