From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tom Rix <trix@redhat.com>
Cc: jasowang@redhat.com, nathan@kernel.org, ndesaulniers@google.com,
lingshan.zhu@intel.com, sgarzare@redhat.com,
xieyongji@bytedance.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] vDPA/ifcvf: match pointer check to use
Date: Tue, 15 Mar 2022 11:15:51 -0400 [thread overview]
Message-ID: <20220315111456-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <512a392d-23d7-c25b-7576-571001f28288@redhat.com>
On Tue, Mar 15, 2022 at 08:03:26AM -0700, Tom Rix wrote:
>
> On 3/15/22 6:28 AM, Michael S. Tsirkin wrote:
> > On Tue, Mar 15, 2022 at 05:41:30AM -0700, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > Clang static analysis reports this issue
> > > ifcvf_main.c:49:4: warning: Called function
> > > pointer is null (null dereference)
> > > vf->vring->cb.callback(vring->cb.private);
> > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >
> > > The check
> > > vring = &vf->vring[i];
> > > if (vring->cb.callback)
> > >
> > > Does not match the use. Change dereference so they match.
> > >
> > > Fixes: 79333575b8bd ("vDPA/ifcvf: implement shared IRQ feature")
> > Thanks a lot! I squashed this into the offending patch - no point in
> > breaking bisect. Pushed to linux. However I'm now
> > having second thoughts about applying that patchset - I'd like
> > soma analysis explaining how this got through testing.
>
> static analysis is something i do treewide.
>
> There are currently ~2500 issues in linux-next, do not panic! many are false
> positives.
>
> It is pretty easy to setup and once you have a baseline you can filter only
> your files.
>
> Tom
Thanks for that info! I was actually directing this question to the
contributor since the code does not look like it could have ever
worked. I don't have the hardware in question myself.
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > ---
> > > drivers/vdpa/ifcvf/ifcvf_main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> > > index 3b48e717e89f7..4366320fb68d3 100644
> > > --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> > > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> > > @@ -46,7 +46,7 @@ static irqreturn_t ifcvf_vqs_reused_intr_handler(int irq, void *arg)
> > > for (i = 0; i < vf->nr_vring; i++) {
> > > vring = &vf->vring[i];
> > > if (vring->cb.callback)
> > > - vf->vring->cb.callback(vring->cb.private);
> > > + vring->cb.callback(vring->cb.private);
> > > }
> > > return IRQ_HANDLED;
> > > --
> > > 2.26.3
next prev parent reply other threads:[~2022-03-15 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 12:41 [PATCH] vDPA/ifcvf: match pointer check to use trix
2022-03-15 13:23 ` Michael S. Tsirkin
2022-03-15 13:28 ` Michael S. Tsirkin
2022-03-15 15:03 ` Tom Rix
2022-03-15 15:15 ` Michael S. Tsirkin [this message]
2022-03-16 2:25 ` Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315111456-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sgarzare@redhat.com \
--cc=trix@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).