From: Xiaomeng Tong <xiam0nd.tong@gmail.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: christopher.lee@cspi.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Xiaomeng Tong <xiam0nd.tong@gmail.com>
Subject: [PATCH] myri10ge: remove an unneed NULL check
Date: Sat, 19 Mar 2022 13:23:50 +0800 [thread overview]
Message-ID: <20220319052350.26535-1-xiam0nd.tong@gmail.com> (raw)
The define of skb_list_walk_safe(first, skb, next_skb) is:
for ((skb) = (first), (next_skb) = (skb) ? (skb)->next : NULL; (skb); \
(skb) = (next_skb), (next_skb) = (skb) ? (skb)->next : NULL)
Thus, if the 'segs' passed as 'first' into the skb_list_walk_safe is NULL,
the loop will exit immediately. In other words, it can be sure the 'segs'
is non-NULL when we run inside the loop. So just remove the unnecessary
NULL check.
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 50ac3ee2577a..424160dd650c 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -2903,12 +2903,10 @@ static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb,
status = myri10ge_xmit(curr, dev);
if (status != 0) {
dev_kfree_skb_any(curr);
- if (segs != NULL) {
- curr = segs;
- segs = next;
- curr->next = NULL;
- dev_kfree_skb_any(segs);
- }
+ curr = segs;
+ segs = next;
+ curr->next = NULL;
+ dev_kfree_skb_any(segs);
goto drop;
}
}
--
2.17.1
reply other threads:[~2022-03-19 5:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220319052350.26535-1-xiam0nd.tong@gmail.com \
--to=xiam0nd.tong@gmail.com \
--cc=christopher.lee@cspi.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).