From: Willy Tarreau <w@1wt.eu>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
Nugraha <richiisei@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
llvm@lists.linux.dev
Subject: Re: [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang
Date: Sun, 20 Mar 2022 20:16:19 +0100 [thread overview]
Message-ID: <20220320191619.GA27312@1wt.eu> (raw)
In-Reply-To: <20220320093750.159991-3-ammarfaizi2@gnuweeb.org>
Hi Ammar,
I've had a look at this one.
On Sun, Mar 20, 2022 at 04:37:46PM +0700, Ammar Faizi wrote:
> Budilig with clang yields the following error:
^^^^^^^
BTW please fix the typo in the final commit message.
> @@ -183,7 +183,9 @@ struct sys_stat_struct {
>
> /* startup code */
> asm(".section .text\n"
> +#if !defined(__clang__)
> ".weak _start\n"
> +#endif
> ".global _start\n"
> "_start:\n"
So it seems that I was wrong and that .weak is an alternate for .global
and not a complement. As such, instead of adding all these #if, please
simply remove all .global.
Thanks!
Willy
next prev parent reply other threads:[~2022-03-20 19:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 9:37 [RFC PATCH v1 0/6] Add dynamic memory allocator support for nolibc Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 1/6] tools/nolibc: x86-64: Update System V ABI document link Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang Ammar Faizi
2022-03-20 19:16 ` Willy Tarreau [this message]
2022-03-21 11:38 ` Ammar Faizi
2022-03-21 17:27 ` Nick Desaulniers
2022-03-20 9:37 ` [RFC PATCH v1 3/6] tools/nolibc: i386: Implement syscall with 6 arguments Ammar Faizi
2022-03-20 10:33 ` Alviro Iskandar Setiawan
2022-03-20 10:42 ` Alviro Iskandar Setiawan
2022-03-20 15:09 ` Ammar Faizi
2022-03-20 13:10 ` David Laight
2022-03-20 14:01 ` Willy Tarreau
2022-03-20 15:04 ` Ammar Faizi
2022-03-20 18:22 ` David Laight
2022-03-20 9:37 ` [RFC PATCH v1 4/6] tools/nolibc/sys: Implement `mmap()` and `munmap()` Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 5/6] tools/nolibc/stdlib: Implement `malloc()`, `calloc()`, `realloc()` and `free()` Ammar Faizi
2022-03-20 15:50 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-20 16:16 ` Willy Tarreau
2022-03-20 16:36 ` Ammar Faizi
2022-03-20 16:46 ` Willy Tarreau
2022-03-20 9:37 ` [RFC PATCH v1 6/6] tools/include/string: Implement `strdup()` and `strndup()` Ammar Faizi
2022-03-20 15:55 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-21 7:53 ` Willy Tarreau
2022-03-21 8:16 ` Alviro Iskandar Setiawan
2022-03-21 8:51 ` Willy Tarreau
2022-03-21 11:36 ` Ammar Faizi
2022-03-21 11:43 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220320191619.GA27312@1wt.eu \
--to=w@1wt.eu \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=richiisei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).