[PATCH V2 0/2] add ddr controller node to support EDAC on imx8mp

[PATCH V2 0/2] add ddr controller node to support EDAC on imx8mp

[Sherry Sun]

First fix the errors for snps,ddrc-3.80a in DT bindings, then add the device
node to support EDAC on imx8mp.

Changes in V2:
* Suggested by Krzysztof, fix the error for snps,ddrc-3.80a compatible in
synopsys,ddrc-ecc.yaml, then add the dts node in device tree.

Sherry Sun (2):
  dt-bindings: memory: snps,ddrc-3.80a compatible also need interrupts
  arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp

 .../bindings/memory-controllers/synopsys,ddrc-ecc.yaml      | 6 ++++--
 arch/arm64/boot/dts/freescale/imx8mp.dtsi                   | 6 ++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

-- 
2.17.1

[PATCH V2 1/2] dt-bindings: memory: snps,ddrc-3.80a compatible also need interrupts

[Sherry Sun]

For the snps,ddrc-3.80a compatible, the interrupts property is also
required, also order the compatibles by name (s goes before x).

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 .../bindings/memory-controllers/synopsys,ddrc-ecc.yaml      | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml b/Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml
index fb7ae38a9c86..e3bc6ebce090 100644
--- a/Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml
@@ -24,9 +24,9 @@ description: |
 properties:
   compatible:
     enum:
+      - snps,ddrc-3.80a
       - xlnx,zynq-ddrc-a05
       - xlnx,zynqmp-ddrc-2.40a
-      - snps,ddrc-3.80a
 
   interrupts:
     maxItems: 1
@@ -43,7 +43,9 @@ allOf:
       properties:
         compatible:
           contains:
-            const: xlnx,zynqmp-ddrc-2.40a
+            enum:
+              - snps,ddrc-3.80a
+              - xlnx,zynqmp-ddrc-2.40a
     then:
       required:
         - interrupts
-- 
2.17.1

[PATCH V2 2/2] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp

[Sherry Sun]

i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support
for i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 3f8703f3ba5b..f39da2b12ddc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -902,6 +902,12 @@
 			interrupt-parent = <&gic>;
 		};
 
+		edacmc: memory-controller@3d400000 {
+			compatible = "snps,ddrc-3.80a";
+			reg = <0x3d400000 0x400000>;
+			interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
+		};
+
 		ddr-pmu@3d800000 {
 			compatible = "fsl,imx8mp-ddr-pmu", "fsl,imx8m-ddr-pmu";
 			reg = <0x3d800000 0x400000>;
-- 
2.17.1

Re: [PATCH V2 2/2] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp

[Krzysztof Kozlowski]

On 21/03/2022 08:51, Sherry Sun wrote:
> i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support
> for i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver.
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 3f8703f3ba5b..f39da2b12ddc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -902,6 +902,12 @@
>  			interrupt-parent = <&gic>;
>  		};
>  

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof

Re: [PATCH V2 1/2] dt-bindings: memory: snps,ddrc-3.80a compatible also need interrupts

[Krzysztof Kozlowski]

On 21/03/2022 08:51, Sherry Sun wrote:
> For the snps,ddrc-3.80a compatible, the interrupts property is also
> required, also order the compatibles by name (s goes before x).
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
>  .../bindings/memory-controllers/synopsys,ddrc-ecc.yaml      | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Fixes: a9e6b3819b36 ("dt-bindings: memory: Add entry for version 3.80a")


Looks good, I will take it after merge window. Somehow I was not cc-ed
on previous memory controllers patch. :(

Best regards,
Krzysztof

Re: (subset) [PATCH V2 1/2] dt-bindings: memory: snps,ddrc-3.80a compatible also need interrupts

[Krzysztof Kozlowski]

On Mon, 21 Mar 2022 15:51:30 +0800, Sherry Sun wrote:
> For the snps,ddrc-3.80a compatible, the interrupts property is also
> required, also order the compatibles by name (s goes before x).
> 
> 

Applied, thanks!

[1/2] dt-bindings: memory: snps,ddrc-3.80a compatible also need interrupts
      commit: 4f9f45d0eb0e7d449bc9294459df79b9c66edfac

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH V2 2/2] arm64: dts: imx8mp: add ddr controller node to support EDAC on imx8mp

[Shawn Guo]

On Mon, Mar 21, 2022 at 03:51:31PM +0800, Sherry Sun wrote:
> i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support
> for i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver.
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>

Applied, thanks!