From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xiantao Hu <xt.hu@cqplus1.com>
Cc: wim@linux-watchdog.org, p.zabel@pengutronix.de,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux@roeck-us.net, robh+dt@kernel.org,
devicetree@vger.kernel.org, wells.lu@sunplus.com,
qinjian@cqplus1.com, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v7 1/2] dt-bindings: watchdog: Add watchdog yaml file for Sunplus SP7021
Date: Mon, 21 Mar 2022 12:10:05 +0100 [thread overview]
Message-ID: <20220321111005.w27blherwnon6kwk@krzk-bin> (raw)
In-Reply-To: <20220304081209.672-2-xt.hu@cqplus1.com>
On Fri, Mar 04, 2022 at 04:12:08PM +0800, Xiantao Hu wrote:
> This adds the documentation for the devicetree bindings of the Sunplus
> SP7021 watchdog driver, found from SP7021 SoCs and newer.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Xiantao Hu <xt.hu@cqplus1.com>
> ---
> .../bindings/watchdog/sunplus,sp7021-wdt.yaml | 47 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
Please use scripts/get_maintainer.pl on recent kernel (newest mainline or
recent linux-next) to get the list of people to CC.
>
> diff --git a/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> new file mode 100644
> index 000000000..9a9bfe150
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/sunplus,sp7021-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SoCs Watchdog Device Tree Bindings
s/Device Tree Bindings//
> +
> +maintainers:
> + - XianTao Hu <xt.hu@cqplus1.com>
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-wdt
> +
> + reg:
> + items:
> + - description: watchdog registers regions
> + - description: miscellaneous control registers regions
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + watchdog: watchdog@9c000630 {
> + compatible = "sunplus,sp7021-wdt";
> + reg = <0x9c000630 0x08>, <0x9C000274 0x04>;
lowercase hex (Second reg)
Can be fixed while applying, so in such case:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-21 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 8:12 [PATCH v7 0/2] Add watchdog driver for Sunplus SP7021 SoC Xiantao Hu
2022-03-04 8:12 ` [PATCH v7 1/2] dt-bindings: watchdog: Add watchdog yaml file for Sunplus SP7021 Xiantao Hu
2022-03-21 11:10 ` Krzysztof Kozlowski [this message]
2022-03-21 12:20 ` xt.hu[胡先韬]
2022-03-04 8:12 ` [PATCH v7 2/2] watchdog: Add watchdog driver " Xiantao Hu
2022-03-09 23:11 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321111005.w27blherwnon6kwk@krzk-bin \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wells.lu@sunplus.com \
--cc=wim@linux-watchdog.org \
--cc=xt.hu@cqplus1.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).