From: Guenter Roeck <linux@roeck-us.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Harsha <harsha.harsha@xilinx.com>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] cacheflush.h: Add forward declaration for struct folio
Date: Tue, 22 Mar 2022 21:10:30 -0700 [thread overview]
Message-ID: <20220323041030.GA2968769@roeck-us.net> (raw)
On Wed, Mar 23, 2022 at 03:35:10PM +1200, Herbert Xu wrote:
> On Tue, Mar 22, 2022 at 06:13:27AM -0700, Guenter Roeck wrote:
> > On Wed, Mar 09, 2022 at 03:20:01PM +1200, Herbert Xu wrote:
> > > This patch turns the new SHA driver into a tristate and also allows
> > > compile testing.
> > >
> > > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> >
> > This results in:
> >
> > Building s390:allmodconfig ... failed
> > --------------
> > Error log:
> > In file included from drivers/crypto/xilinx/zynqmp-sha.c:6:
> > include/linux/cacheflush.h:12:46: error: 'struct folio' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > 12 | static inline void flush_dcache_folio(struct folio *folio)
>
> This should be fixed in cacheflush.h:
>
> ---8<---
> The struct folio is not declared in cacheflush.h so we need to
> provide a forward declaration as otherwise users of this header
> file may get warnings.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: 522a0032af00 ("Add linux/cacheflush.h")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
>
> diff --git a/include/linux/cacheflush.h b/include/linux/cacheflush.h
> index fef8b607f97e..a6189d21f2ba 100644
> --- a/include/linux/cacheflush.h
> +++ b/include/linux/cacheflush.h
> @@ -4,6 +4,8 @@
>
> #include <asm/cacheflush.h>
>
> +struct folio;
> +
> #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
> #ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO
> void flush_dcache_folio(struct folio *folio);
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next reply other threads:[~2022-03-23 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 4:10 Guenter Roeck [this message]
[not found] <Yigc4cQlTJRRZsQg@gondor.apana.org.au>
[not found] ` <20220322131327.GA747088@roeck-us.net>
2022-03-23 3:35 ` [PATCH] cacheflush.h: Add forward declaration for struct folio Herbert Xu
2022-03-23 12:43 ` Matthew Wilcox
2022-03-23 17:11 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323041030.GA2968769@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=harsha.harsha@xilinx.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).