From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4B6AC433F5 for ; Wed, 23 Mar 2022 13:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244382AbiCWNoz (ORCPT ); Wed, 23 Mar 2022 09:44:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236735AbiCWNox (ORCPT ); Wed, 23 Mar 2022 09:44:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E6399E08C for ; Wed, 23 Mar 2022 06:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648043002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IJHOsMD+p/TxrB7WMAz/bVsoyRgqHIkadq0oUUT9qqg=; b=GDc+7s+0yi95INhB0p3FYtjdQaWluWuzUtwxyLHJCCx2qWADXGUaR+uYsWORoH5FyHrTsu eAqiRaXeghwQjccYHOkKlMvncWgaZse3tSbvJhTkW6dzEepFp4O2mfm9L6SWhcUjMzLJzR JJvAUXnNAFYritCLDv/uA6neE/rUeNI= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-vUsLtJYHPJeblUuYl6bAiQ-1; Wed, 23 Mar 2022 09:43:20 -0400 X-MC-Unique: vUsLtJYHPJeblUuYl6bAiQ-1 Received: by mail-qt1-f199.google.com with SMTP id p6-20020a05622a00c600b002e1cb9508e8so1167175qtw.20 for ; Wed, 23 Mar 2022 06:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IJHOsMD+p/TxrB7WMAz/bVsoyRgqHIkadq0oUUT9qqg=; b=x0c0tkCC0wNwUDc2Y6FAnD0deQCIt6hJwx07o1gx/zaQdBY6wIfO3IXqnojid9ilDU bUKAFMU+pkOsvjwW99IvbL/Ow8eBpXDFF7/diIsX7+4s3VtzHQ5XlUNTook9M/JuP2MY YpgzlfvoIqSZME8Kb7T6+T/RXqSO49y6iBp4URUoycaeM3AxM5Vas6eiZ25hXfjtPW3P LK564HePYqvr8xmfnL68Kl73og7xevjsso6uGYPQgd6xyN87ruwdX9QI3y4R9gxnE+12 CYzUlFXeAx5klBYMT0P7fyZc3/W11jMveRhyreooTAaFIy+DOAnSNkZnUoQ0wyetqESD 81zQ== X-Gm-Message-State: AOAM53228YB45Acg3mfszhryv6erY3YEE1k2OS3VN57tfk9Ga+DqT3Mr A/d9acBv0SlDwfONWuY74KflcmL1fzK5ubZywFJC7AFM1OakS9UN40hI99HfZYAeKrMSOVZFN43 DMoOCc+cNNCXC17tTs+n1g5gd X-Received: by 2002:a05:622a:1111:b0:2e1:e831:2ee2 with SMTP id e17-20020a05622a111100b002e1e8312ee2mr23861904qty.264.1648043000028; Wed, 23 Mar 2022 06:43:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn19Zj7+5jT24adJG336cYAb3ONCKQCObx38/CuWziIHD5QGZCRUCxyzDDeqQ7YzreKx5W0Q== X-Received: by 2002:a05:622a:1111:b0:2e1:e831:2ee2 with SMTP id e17-20020a05622a111100b002e1e8312ee2mr23861884qty.264.1648042999740; Wed, 23 Mar 2022 06:43:19 -0700 (PDT) Received: from sgarzare-redhat (host-87-12-25-114.business.telecomitalia.it. [87.12.25.114]) by smtp.gmail.com with ESMTPSA id 20-20020ac84e94000000b002e1d5505fb6sm54700qtp.63.2022.03.23.06.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 06:43:19 -0700 (PDT) Date: Wed, 23 Mar 2022 14:43:13 +0100 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, Stefan Hajnoczi , Paolo Abeni , Arseny Krasnov , "David S. Miller" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Asias He , Jakub Kicinski Subject: Re: [PATCH net v2 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them Message-ID: <20220323134313.rmx24o3534rmgp3u@sgarzare-redhat> References: <20220323084954.11769-1-sgarzare@redhat.com> <20220323092118-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220323092118-mutt-send-email-mst@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 09:22:02AM -0400, Michael S. Tsirkin wrote: >On Wed, Mar 23, 2022 at 09:49:51AM +0100, Stefano Garzarella wrote: >> The first patch fixes a virtio-spec violation. The other two patches >> complete the driver configuration before using the VQs in the probe. >> >> The patch order should simplify backporting in stable branches. > >Ok but I think the order is wrong. It should be 2-3-1, >otherwise bisect can pick just 1 and it will have >the issues previous reviw pointed out. Right, I prioritized simplifying the backport, but obviously bisectability is priority! I'll send v3 changing the order in 2-3-1 Thanks, Stefano