From: Kees Cook <keescook@chromium.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
kernel test robot <oliver.sang@intel.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>,
John Garry <john.garry@huawei.com>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, lkp@intel.com, linux-mm@kvack.org,
linux-hardening@vger.kernel.org
Subject: Re: [scsi] 6aded12b10: kernel_BUG_at_mm/usercopy.c
Date: Wed, 23 Mar 2022 15:30:44 -0700 [thread overview]
Message-ID: <202203231529.0CB76344@keescook> (raw)
In-Reply-To: <Yjs/6pLB1uDKBRCG@casper.infradead.org>
On Wed, Mar 23, 2022 at 03:42:34PM +0000, Matthew Wilcox wrote:
> On Wed, Mar 23, 2022 at 08:40:30AM -0700, Kees Cook wrote:
> > On Wed, Mar 23, 2022 at 08:14:10AM +0100, Christoph Hellwig wrote:
> > > The actual warning is;
> > >
> > > [ 34.496096][ T331] usercopy: Kernel memory overwrite attempt detected to spans multiple pages (off set 0, size 6)!
> > >
> > > This is for the cmnd field in struct scsi_cmnd, which is allocated by
> > > the block layer as part of the request allocator. So with a specific
> > > packing it can legitimately span pages.
> > >
> > > Kees: how can we annotate that this is ok?
> >
> > The main problem is that CONFIG_HARDENED_USERCOPY_PAGESPAN=y is broken
> > (and nothing should be setting it).
> >
> > This series removes it:
> > https://lore.kernel.org/linux-hardening/20220110231530.665970-1-willy@infradead.org/
> >
> > Matthew, what's the status of that series? Will it make the current
> > merge window?
>
> I thought you were going to merge it! I haven't put it in any of my
> public trees.
LOL. Okay, you'd mentioned another check, so I wasn't sure. I can go
ahead and snag it, but I'll likely wait until the next window and let it
live in -next for a while, unless you think it should get YOLOed in. :)
-Kees
--
Kees Cook
next prev parent reply other threads:[~2022-03-23 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 14:34 [scsi] 6aded12b10: kernel_BUG_at_mm/usercopy.c kernel test robot
2022-03-23 7:14 ` Christoph Hellwig
2022-03-23 15:40 ` Kees Cook
2022-03-23 15:42 ` Matthew Wilcox
2022-03-23 22:30 ` Kees Cook [this message]
2022-03-23 15:47 ` Christoph Hellwig
2022-03-23 22:33 ` Kees Cook
2022-03-24 6:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203231529.0CB76344@keescook \
--to=keescook@chromium.org \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=martin.petersen@oracle.com \
--cc=oliver.sang@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).