From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB07C433F5 for ; Thu, 24 Mar 2022 09:05:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349114AbiCXJGe (ORCPT ); Thu, 24 Mar 2022 05:06:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238929AbiCXJGc (ORCPT ); Thu, 24 Mar 2022 05:06:32 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A9FE19D0E2; Thu, 24 Mar 2022 02:05:00 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nXJOs-0002LV-01; Thu, 24 Mar 2022 10:04:58 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 40811C2ECE; Thu, 24 Mar 2022 10:04:43 +0100 (CET) Date: Thu, 24 Mar 2022 10:04:43 +0100 From: Thomas Bogendoerfer To: Michal Hocko Cc: kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Oscar Salvador , Andrew Morton , Linux Memory Management List , linux-mips@vger.kernel.org Subject: Re: undefined reference to `node_data' Message-ID: <20220324090443.GA5375@alpha.franken.de> References: <202203232042.AS9SV1zv-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 05:46:59PM +0100, Michal Hocko wrote: > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All errors (new ones prefixed by >>): > > > > > > mips64-linux-ld: mm/page_alloc.o: in function `free_area_init': > > > >> (.init.text+0x1680): undefined reference to `node_data' > > > mips64-linux-ld: (.init.text+0x1690): undefined reference to `node_data' > > > > OK, I can see what is going here. The page allocator normally > > uses NODE_DATA but arch_refresh_nodedata refers to node_data directly. > > This is a problem with > > arch/mips/include/asm/mach-loongson64/mmzone.h: > > extern struct pglist_data *__node_data[]; > > > > #define NODE_DATA(n) (__node_data[n]) > > > > Unfortunately we cannot use NODE_DATA there because of header inclusion > > ordering. I will think about a solution. > > Is there any reason why (some?) MIPS arches use __node_data rather than > node_data as most other architectures? Would it be acceptable to do the > renaming? It would help to cover the above compilation problem because > arch_refresh_nodedata could keep using node_data directly. I've just checked history and I don't see a reason for __node_data. So I'm fine with changing it to node_data. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]