From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BE0C433F5 for ; Thu, 24 Mar 2022 12:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350132AbiCXM0X (ORCPT ); Thu, 24 Mar 2022 08:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244214AbiCXM0S (ORCPT ); Thu, 24 Mar 2022 08:26:18 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75546A66C5 for ; Thu, 24 Mar 2022 05:24:46 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id v4so4586440pjh.2 for ; Thu, 24 Mar 2022 05:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QxjC77/AG75v2VbEzHzDJddv3BOZKFG+BN1obowdbeM=; b=wZamSwGHrvBdyO4Q2dpcKPbHF0iVv/vgPMOqnQHHXxXyvCMZW9RsT2+pQhmmJ4uy/r elafkhjGL3lEzC1xrHY438WM3FecrbOg4sRK9ZUrCyZ9QeQqIQUCyJO8pz5qDGM0ieON q25V45p5s7lI0nyazNjCdNv06eFYz8jLCDLMvuDejX37hawZK2+UoR9fyQVHsnpXCtJH LikFtRw+NV/gs4bhWdpShfGqeKwdtVDMOKid+bXFLa8+NvIrXtpg6VpU4cv0NAFbD8ys HGWUbWFJDFX7xpHU4bQYruclDKDJPrf5PkRD+gMVA5KGDcF8PZK7ul5pY/oevT6ffjHP R96w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QxjC77/AG75v2VbEzHzDJddv3BOZKFG+BN1obowdbeM=; b=xK6CQYH+3TaZxm3ukTQly7IReJCRDsmV5cPnNLK5wW8F+6V6IkpIsv9OCPPMNOM5Kz kOZX/JEOjnlKSx6LrvWQovg3fubiR6OG4rNnqJudbldxnN7Nude2XzCEu0q1/kNFbOcL gt7Jon/niFw0k4hzLAhov36SEfIKQTViXiRRZGUvAfBN/mCTyKG+MQTD1lVpQPLTfGmh //N8fPAOUl93Jj5UfLeFM1h7ToNkN71njCGcTLdkn40Xww3JRSnQzce9xJ6CNMEmKBO2 41PJDV1gtjbmUb0Xu1JuLxlEk1+NM4kMGxS5G4giHbXEL+iqRyTonodChDOzu0/GjNL8 Ay9A== X-Gm-Message-State: AOAM530rlpxq34k36+UUSN8C+baON6G2eTaGy3i9/PTApGE0rAOi2jDZ iAOeeAVgBrYz1XPGxTIwV2Ii X-Google-Smtp-Source: ABdhPJwOaNNyUJ5HdUnz+nscJzh+cyXkOeP5AwavPCeBrAcfzKJBvsIwEmNo25guWT7RDEea3jAoKQ== X-Received: by 2002:a17:902:f70d:b0:14f:a1e1:b9b3 with SMTP id h13-20020a170902f70d00b0014fa1e1b9b3mr5750034plo.36.1648124685926; Thu, 24 Mar 2022 05:24:45 -0700 (PDT) Received: from thinkpad ([220.158.158.107]) by smtp.gmail.com with ESMTPSA id k17-20020a056a00135100b004fa9df39517sm3546388pfu.198.2022.03.24.05.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 05:24:45 -0700 (PDT) Date: Thu, 24 Mar 2022 17:54:40 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/12] PCI: dwc-plat: Discard unused regmap pointer Message-ID: <20220324122440.GK2854@thinkpad> References: <20220324012524.16784-1-Sergey.Semin@baikalelectronics.ru> <20220324012524.16784-12-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324012524.16784-12-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 04:25:22AM +0300, Serge Semin wrote: > The regmap pointer was added into the dw_plat_pcie structure in > commit 1d906b22076e ("PCI: dwc: Add support for EP mode"), but it hasn't > been utilized neither in the code submitted in the denoted so far nor in > the platform driver evolving afterwards. Drop it then for good. > > Signed-off-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-designware-plat.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c > index fea785096261..99cf2ac5b0ba 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-plat.c > +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c > @@ -17,13 +17,11 @@ > #include > #include > #include > -#include > > #include "pcie-designware.h" > > struct dw_plat_pcie { > struct dw_pcie *pci; > - struct regmap *regmap; > enum dw_pcie_device_mode mode; > }; > > -- > 2.35.1 >