From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6DECC433F5 for ; Thu, 24 Mar 2022 12:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350133AbiCXM2f (ORCPT ); Thu, 24 Mar 2022 08:28:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350184AbiCXM17 (ORCPT ); Thu, 24 Mar 2022 08:27:59 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3509FA66CB for ; Thu, 24 Mar 2022 05:26:28 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id bx5so4576020pjb.3 for ; Thu, 24 Mar 2022 05:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8xPB47npQGsnbqow09+7e0pd72NIwb8sCoRSdsw0rcA=; b=vrJr+tlTZcRn5istxlaDHcI6wE1uChrM30Js6/44rpTdqQoJs1Vy/K91SMYxMyMA+R aRumGVFQQFXUpQ0nGGkqSAQ+KqiAAJEu6hJTyzqomEqxw7FiRyepEsR3+yW1j4BGQxo4 lfT8PxjtvShOtxu0N8Zw01dcp4QyKfW9/XKJu3kdt8ghAU1R9LyuFc8gJchfzovACGvB aVqTqb8U4dLAzNTz3HRe+ZFOoW7wg8fMdM/O9Tp9AI8p2fuuNo2w8VxCzRqN9djd7nzG lcs0ihtcWtR8fT5ukAfP1pGloGIQyLbPLVT8aHQzYHjy2/am/GRYK4KGR8kMnHJANEEq 1PJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8xPB47npQGsnbqow09+7e0pd72NIwb8sCoRSdsw0rcA=; b=pK1hnnVNBoGPtVOe95FwuYrnL9x5W56LLA/ze0mGDEqkvFdpOJjE2Bsxt5Mzid+gLN wMX4Mx+rWzjMk/ItmRUsAdjqWFjzNHQPxJLLhgEuSNftCq0xQBajJa00nCXa7ivC/cMD 3C8d/JDxQK7Vbh2iT5aYHLCronOXaBApQEMOlvDqHq0VSG8rUkPHKfHHuB7WzM0rocPc G5s+GLlSA/XPPeSS/epIRIvJAV73x6z1iKHtRMHLlxqEsdHD849OhuHj6l0sLsZOrbC8 5yhYhGaw0dr1iL53ttWtJwXVFL2Gc8gv4vNGshaHDjnohloRia61TVy8jdZVe6bY1Whp wcAQ== X-Gm-Message-State: AOAM531s48rgYzmxL/3RiUuyjUR64U0wj5dhFeeO0NlbyrFX4hnrRcC+ VMbPpuQQEr9JgW0thptLcThS X-Google-Smtp-Source: ABdhPJwER0TSTDdBy2gEGVCvbb9B0sORoebwMAZCAoXFYk5F/lfONzwOdTpCjbj5Hhm1rdprbaSdrg== X-Received: by 2002:a17:903:1210:b0:151:fa59:95ef with SMTP id l16-20020a170903121000b00151fa5995efmr5788482plh.57.1648124787671; Thu, 24 Mar 2022 05:26:27 -0700 (PDT) Received: from thinkpad ([220.158.158.107]) by smtp.gmail.com with ESMTPSA id ep2-20020a17090ae64200b001c6a7c22aedsm2753630pjb.37.2022.03.24.05.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 05:26:27 -0700 (PDT) Date: Thu, 24 Mar 2022 17:56:21 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Frank Li , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/12] PCI: dwc-plat: Drop dw_plat_pcie_of_match forward declaration Message-ID: <20220324122621.GL2854@thinkpad> References: <20220324012524.16784-1-Sergey.Semin@baikalelectronics.ru> <20220324012524.16784-13-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324012524.16784-13-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 04:25:23AM +0300, Serge Semin wrote: > The denoted forward declaration used to be required to get the OF-device > ID structure by calling the of_match_device() method. The later method > invocation has been replaced with the of_device_get_match_data() call in > the commit 5c204204cf24 ("PCI: designware-plat: Prefer > of_device_get_match_data()"). Thus the forward declaration of the > OF-compatible device strings no longer needed. Drop it for good. > > Signed-off-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-designware-plat.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c > index 99cf2ac5b0ba..e606c5d5f06f 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-plat.c > +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c > @@ -29,8 +29,6 @@ struct dw_plat_pcie_of_data { > enum dw_pcie_device_mode mode; > }; > > -static const struct of_device_id dw_plat_pcie_of_match[]; > - > static const struct dw_pcie_host_ops dw_plat_pcie_host_ops = { > }; > > -- > 2.35.1 >