From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E3E0C433EF for ; Thu, 24 Mar 2022 17:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352366AbiCXRn4 (ORCPT ); Thu, 24 Mar 2022 13:43:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234980AbiCXRny (ORCPT ); Thu, 24 Mar 2022 13:43:54 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E388EA996C for ; Thu, 24 Mar 2022 10:42:22 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id g19so4514675pfc.9 for ; Thu, 24 Mar 2022 10:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ix5HG5X7RmrL9dqKstRw1McRJWsiK0E5jqwyDOBzbuM=; b=xfj3Sf7SWDJmay18REWrHUEbMiiizgTKly7sMrGNxPPdCYvY9Ch3QjLZJI4gktckpC UDBq7zZ/egwEHGSl9U16/DCC6mSzPcTxLERGrPNReQcGP8KwbpwxkE9ctyL+6m7kCRUp ojEPFW+1z5qtCZ6SKfr1kkMYaMTb2VBGXEyUWXqCk0CzzkebLk351MDTAJIN6dE5p8NO NtWuj6Sx+VHZrNtuQo+AXq2ja/yKDt7sJAo5uVJupZmS/an+vjp7WpTgu6SlgMxt/qBm H8XOXfcY+dvnFgniIZPq+VYitCyD3WPgLzuKaGA5JyP8TFt+nrVfftGM57173hD94PMi Jt5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ix5HG5X7RmrL9dqKstRw1McRJWsiK0E5jqwyDOBzbuM=; b=fQZDyEMpfiCi8vl/bS3KEayKt8yPClf4u0TTI0bdtWljZMXe+D/D61Dvy7H6nx2nfE GKeakRV5qTBUXu7PJc1Ud+pNXibm4iQLdLJWbszIHxtjrC24yR6SAZKE5Sv29bkdIZ6z 2SD5nlnQooQz5PKP+jFk9+rfe6J0/fQe2ubEUcP7AkZs9otXEkAdjr1B3b6iIH1hecra DifVtvAw/YQVq0MB6if2OgHsKw/pcP9V6L634mQnYEGMy+j1k8bEzqkul1OgVi09p4kY Sht8xrJWbCMH2cQLX4GkKBSo9SBzP+MXMMVIMXOidzU7c4D9Z6QmKA1FZBGUJVokSnDr vOzw== X-Gm-Message-State: AOAM5323V6CNpI2uSxrjKjTpBpK8l/MC/MWs3YV+QImHtxkNRGOJsIF3 gmc1FkNaVKtXYI7f5nmfbw2M X-Google-Smtp-Source: ABdhPJxiQ+OgZfcH81lzbRsE3Ak3wQ3W1on0G5tEEVL+3WsF550yVWf0drsfblSExo8Ivg5S5Q8nfw== X-Received: by 2002:a65:6a4a:0:b0:380:fd52:1677 with SMTP id o10-20020a656a4a000000b00380fd521677mr4731957pgu.597.1648143742395; Thu, 24 Mar 2022 10:42:22 -0700 (PDT) Received: from thinkpad ([27.111.75.218]) by smtp.gmail.com with ESMTPSA id u37-20020a056a0009a500b004f820de3dcdsm4353788pfg.9.2022.03.24.10.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 10:42:22 -0700 (PDT) Date: Thu, 24 Mar 2022 23:12:15 +0530 From: Manivannan Sadhasivam To: Serge Semin Cc: Gustavo Pimentel , Vinod Koul , Jingoo Han , Bjorn Helgaas , Frank Li , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/25] dmaengine: dw-edma: Drop chancnt initialization Message-ID: <20220324174215.GT2854@thinkpad> References: <20220324014836.19149-1-Sergey.Semin@baikalelectronics.ru> <20220324014836.19149-12-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324014836.19149-12-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 04:48:22AM +0300, Serge Semin wrote: > DMA device drivers aren't supposed to initialize the dma_device.chancnt > field. It will be done by the DMA-engine core in accordance with number of > added virtual DMA-channels. Pre-initializing it with some value causes > having a wrong number of channels printed in the device summary. > > Fixes: e63d79d1ffcd ("dmaengine: Add Synopsys eDMA IP core driver") > Signed-off-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/dma/dw-edma/dw-edma-core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c > index 418b201fef67..cefa73412bf7 100644 > --- a/drivers/dma/dw-edma/dw-edma-core.c > +++ b/drivers/dma/dw-edma/dw-edma-core.c > @@ -823,7 +823,6 @@ static int dw_edma_channel_setup(struct dw_edma_chip *chip, bool write, > dma->src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES); > dma->dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES); > dma->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; > - dma->chancnt = cnt; > > /* Set DMA channel callbacks */ > dma->dev = chip->dev; > -- > 2.35.1 >