From: Christian Vogel <vogelchr@vogel.cx>
To: greg@kroah.com, linux-kernel@vger.kernel.org
Cc: zbr@ioremap.net, vogelchr@vogel.cx
Subject: w1/ds2490: fix excessive logging
Date: Thu, 24 Mar 2022 20:32:45 +0100 [thread overview]
Message-ID: <20220324193246.16814-1-vogelchr@vogel.cx> (raw)
In-Reply-To: <YjSD8us/T3eHDwB2@kroah.com>
As suggested by Greg, I've sorted the many pr_info calls in ds2490
that were used for rather eclectic logging into dev_info/dev_debug
instead of my first attempt of introducing a module parameter. Now
debugging should cease for the normal configurations without DEBUG.
Only the first two lines will show up, and the status will not be
extensively decoded/commented.
kern :info : [293529.095345] usb 2-1.3.1: Clearing ep0x83.
kern :info : [293529.097271] usb 2-1.3.1: ep_status=0x81,
count=16, status=01:00:20:40:05:04:04:00:20:53:00:00:00:00:00:00
kern :debug : [293529.097282] usb 2-1.3.1: enable flag: 0x01
kern :debug : [293529.097286] usb 2-1.3.1: 1-wire speed: 0x00
kern :debug : [293529.097290] usb 2-1.3.1: strong pullup duration: 0x20
kern :debug : [293529.097293] usb 2-1.3.1: programming pulse duration: 0x40
kern :debug : [293529.097297] usb 2-1.3.1: pulldown slew rate control: 0x05
kern :debug : [293529.097300] usb 2-1.3.1: write-1 low time: 0x04
kern :debug : [293529.097304] usb 2-1.3.1: data sample offset/write-0 recovery time: 0x04
kern :debug : [293529.097308] usb 2-1.3.1: reserved (test register): 0x00
kern :debug : [293529.097311] usb 2-1.3.1: device status flags: 0x20
kern :debug : [293529.097315] usb 2-1.3.1: communication command byte 1: 0x53
kern :debug : [293529.097318] usb 2-1.3.1: communication command byte 2: 0x00
kern :debug : [293529.097322] usb 2-1.3.1: communication command buffer status: 0x00
kern :debug : [293529.097325] usb 2-1.3.1: 1-wire data output buffer status: 0x00
kern :debug : [293529.097329] usb 2-1.3.1: 1-wire data input buffer status: 0x00
next prev parent reply other threads:[~2022-03-24 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 19:28 w1/ds2490: fix excessive logging Christian Vogel
2022-03-11 19:28 ` [PATCH 1/2] w1/ds2490: remove spurious newlines within hexdump Christian Vogel
2022-03-11 19:28 ` [PATCH 2/2] w1/ds2490: remove dump from ds_recv_status & less verbose Christian Vogel
2022-03-18 13:06 ` Greg KH
2022-03-24 19:32 ` Christian Vogel [this message]
2022-03-24 19:32 ` [PATCH 2/2] w1/ds2490: remove dump from ds_recv_status, pr_ to dev_XXX logging Christian Vogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324193246.16814-1-vogelchr@vogel.cx \
--to=vogelchr@vogel.cx \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).