From: Mario Limonciello <mario.limonciello@amd.com>
To: Huang Rui <ray.huang@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: "open list:AMD PSTATE DRIVER" <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 2/3] cpufreq: amd-pstate: Allow replacing existing cpufreq drivers when loaded
Date: Fri, 25 Mar 2022 00:42:27 -0500 [thread overview]
Message-ID: <20220325054228.5247-3-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220325054228.5247-1-mario.limonciello@amd.com>
`amd-pstate` can be compiled as a module. This however can be a
deficiency because `acpi-cpufreq` will be loaded earlier when compiled
into the kernel meaning `amd-pstate` doesn't get a chance.
`acpi-cpufreq` is also unable to be unloaded in this circumstance.
To better improve the usability of `amd-pstate` when compiled as a module,
add an optional module parameter that will force it to replace other
cpufreq drivers at startup.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/cpufreq/amd-pstate.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 9ce75ed11f8e..31a04e818195 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -63,6 +63,11 @@ module_param(shared_mem, bool, 0444);
MODULE_PARM_DESC(shared_mem,
"enable amd-pstate on processors with shared memory solution (false = disabled (default), true = enabled)");
+static bool replace = false;
+module_param(replace, bool, 0444);
+MODULE_PARM_DESC(replace,
+ "replace other cpufreq drivers upon init if necessary");
+
static struct cpufreq_driver amd_pstate_driver;
/**
@@ -598,9 +603,11 @@ static int __init amd_pstate_init(void)
return -ENODEV;
}
- /* don't keep reloading if cpufreq_driver exists */
- if (cpufreq_get_current_driver())
- return -EEXIST;
+ if (cpufreq_get_current_driver()) {
+ ret = replace ? cpufreq_unregister_driver(NULL) : -EEXIST;
+ if (ret)
+ return ret;
+ }
/* capability check */
if (boot_cpu_has(X86_FEATURE_CPPC)) {
--
2.34.1
next prev parent reply other threads:[~2022-03-25 5:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 5:42 [PATCH 0/3] Improve usability for amd-pstate Mario Limonciello
2022-03-25 5:42 ` [PATCH 1/3] cpufreq: Allow passing NULL as the argument for unregistering a driver Mario Limonciello
2022-03-27 13:23 ` Huang Rui
2022-03-25 5:42 ` Mario Limonciello [this message]
2022-03-25 5:42 ` [PATCH 3/3] cpufreq: amd-pstate: Add a module device table Mario Limonciello
2022-03-27 13:27 ` Huang Rui
2022-03-27 11:56 ` [PATCH 0/3] Improve usability for amd-pstate Huang Rui
2022-03-28 22:14 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325054228.5247-3-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).