From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Kajol Jain <kjain@linux.ibm.com>,
James Clark <james.clark@arm.com>,
German Gomez <german.gomez@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Riccardo Mancini <rickyman7@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
Alexander Antonov <alexander.antonov@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH 0/5] Make evlist CPUs more accurate
Date: Sun, 27 Mar 2022 23:24:09 -0700 [thread overview]
Message-ID: <20220328062414.1893550-1-irogers@google.com> (raw)
evlist has all_cpus, computed to be the merge of all evsel CPU maps,
and cpus. cpus may contain more CPUs than all_cpus, as by default cpus
holds all online CPUs whilst all_cpus holds the merge/union from
evsels. For an uncore event there may just be 1 CPU per socket, which
will be a far smaller CPU map than all online CPUs.
These patches change cpus to be called user_cpus, to reflect their
potential user specified nature. The user_cpus are set to be the
current value intersected with all_cpus, so that user_cpus is always a
subset of all_cpus. This fixes printing code for metrics so that
unnecessary blank lines aren't printed.
To make the intersect function perform well, a perf_cpu_map__is_subset
function is added. While adding this function, also use it in
perf_cpu_map__merge to avoid creating a new CPU map for some currently
missed patterns.
Ian Rogers (5):
perf evlist: Rename cpus to user_cpus
perf cpumap: More cpu map reuse by merge.
perf cpumap: Add intersect function.
perf stat: Avoid segv if core.user_cpus isn't set.
perf evlist: Respect all_cpus when setting user_cpus
tools/lib/perf/cpumap.c | 76 ++++++++++++++++++++----
tools/lib/perf/evlist.c | 28 ++++-----
tools/lib/perf/include/internal/evlist.h | 4 +-
tools/lib/perf/include/perf/cpumap.h | 2 +
tools/perf/arch/arm/util/cs-etm.c | 8 +--
tools/perf/arch/arm64/util/arm-spe.c | 2 +-
tools/perf/arch/x86/util/intel-bts.c | 2 +-
tools/perf/arch/x86/util/intel-pt.c | 4 +-
tools/perf/bench/evlist-open-close.c | 2 +-
tools/perf/builtin-ftrace.c | 2 +-
tools/perf/builtin-record.c | 6 +-
tools/perf/builtin-stat.c | 11 ++--
tools/perf/builtin-top.c | 2 +-
tools/perf/util/auxtrace.c | 2 +-
tools/perf/util/bpf_ftrace.c | 4 +-
tools/perf/util/evlist.c | 16 ++---
tools/perf/util/record.c | 6 +-
tools/perf/util/sideband_evlist.c | 2 +-
tools/perf/util/stat-display.c | 2 +-
tools/perf/util/synthetic-events.c | 2 +-
tools/perf/util/top.c | 6 +-
21 files changed, 127 insertions(+), 62 deletions(-)
--
2.35.1.1021.g381101b075-goog
next reply other threads:[~2022-03-28 6:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 6:24 Ian Rogers [this message]
2022-03-28 6:24 ` [PATCH 1/5] perf evlist: Rename cpus to user_cpus Ian Rogers
2022-03-28 20:18 ` Arnaldo Carvalho de Melo
2022-03-28 20:58 ` Ian Rogers
2022-03-28 6:24 ` [PATCH 2/5] perf cpumap: More cpu map reuse by merge Ian Rogers
2022-03-28 20:26 ` Arnaldo Carvalho de Melo
2022-03-28 20:50 ` Ian Rogers
2022-03-28 20:56 ` Arnaldo Carvalho de Melo
2022-03-28 6:24 ` [PATCH 3/5] perf cpumap: Add intersect function Ian Rogers
2022-03-28 20:28 ` Arnaldo Carvalho de Melo
2022-03-28 20:54 ` Ian Rogers
2022-03-28 20:59 ` Arnaldo Carvalho de Melo
2022-03-28 21:25 ` Ian Rogers
2022-03-28 6:24 ` [PATCH 4/5] perf stat: Avoid segv if core.user_cpus isn't set Ian Rogers
2022-03-28 20:32 ` Arnaldo Carvalho de Melo
2022-03-28 20:46 ` Ian Rogers
2022-03-28 6:24 ` [PATCH 5/5] perf evlist: Respect all_cpus when setting user_cpus Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328062414.1893550-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.antonov@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=coresight@lists.linaro.org \
--cc=daniel@iogearbox.net \
--cc=eranian@google.com \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.fastabend@gmail.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kjain@linux.ibm.com \
--cc=kpsingh@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=songliubraving@fb.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).